Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): extend --version print info #356

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat(cmd): extend --version print info #356

merged 2 commits into from
Nov 15, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Nov 14, 2023

Background

As the title suggests. Add extra info such as Go runtime, copy-right, license to dae --version cmd.

Checklist

Full Changelogs

  • feat(cmd): extend --version print info

Issue Reference

NA

Test Result

◆ dae git:(print-info) ✗ ❯❯❯ make                                                                                                                         23:25:00
-no-strip
Compiled /home/kev/Workspace/dae/control/bpf_bpfel.o
Wrote /home/kev/Workspace/dae/control/bpf_bpfel.go
Compiled /home/kev/Workspace/dae/control/bpf_bpfeb.o
Wrote /home/kev/Workspace/dae/control/bpf_bpfeb.go
-DMAX_MATCH_SET_LEN=64 -O2 -Wall -Werror
go build -o dae -trimpath -ldflags "-s -w -X github.com/daeuniverse/dae/cmd.Version=unstable-20231022.r617.7e57531 -X github.com/daeuniverse/dae/common/consts.Max
MatchSetLen_=64"  .
◆ dae git:(print-info) ✗ ❯❯❯ ./dae --version                                                                                                              23:25:04
dae version unstable-20231022.r617.7e57531
go runtime go1.21.1 linux/amd64
Copyright (c) 2023 dae
License GNU AGPLv3 <https://github.com/daeuniverse/dae/blob/main/LICENSE>

@piyoki piyoki added the feature label Nov 14, 2023
@piyoki piyoki self-assigned this Nov 14, 2023
@piyoki piyoki requested a review from a team as a code owner November 14, 2023 16:59
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piyoki piyoki merged commit b7aea95 into main Nov 15, 2023
@piyoki piyoki deleted the print-info branch November 15, 2023 06:58
st0nie pushed a commit to st0nie/dae that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants