Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(Makefile): enable trace module by default #455

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

hero-intelligent
Copy link
Contributor

ci(Makefile): add back GOARCH ?=$(shell go env GOARCH) to enable trace module by default

Background

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

#453 (comment)

Closes #[issue number]

Test Result

ci(Makefile): add back `GOARCH ?=$(shell go env GOARCH)` to enable trace module by default daeuniverse#453 (comment)
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit a1f62c2 into daeuniverse:main Feb 5, 2024
3 checks passed
@hero-intelligent hero-intelligent deleted the patch-1 branch February 5, 2024 16:58
@dae-prow dae-prow bot mentioned this pull request Apr 2, 2024
@dae-prow dae-prow bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants