Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace regexp with regexp2 for better filtering #467

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

xishang0128
Copy link
Contributor

Background

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@xishang0128 xishang0128 requested a review from a team as a code owner March 3, 2024 11:54
@dae-prow dae-prow bot added the chore label Mar 3, 2024
@douglarek
Copy link
Contributor

douglarek commented Mar 3, 2024

What stress test data is available to demonstrate that we indeed need to introduce this dependency to enhance performance? Where does the concept of 'better filtering' manifest?

@xishang0128
Copy link
Contributor Author

What stress test data is available to demonstrate that we indeed need to introduce this dependency to enhance performance? Where does the concept of 'better filtering' manifest?

regexp2 supports more regular expression formats, such as zero-length assertions, etc.

mzz2017
mzz2017 previously approved these changes Mar 7, 2024
mzz2017
mzz2017 previously approved these changes Mar 7, 2024
@sumire88 sumire88 requested a review from mzz2017 March 28, 2024 11:09
@mzz2017 mzz2017 merged commit 713d991 into daeuniverse:main Apr 2, 2024
17 checks passed
@dae-prow dae-prow bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants