Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): Fix MergeAndSortRulesOptimizer #682

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

jschwinger233
Copy link
Member

Background

Without this patch, mac('2c:9e:00:7a:26:38') -> proxy followed by !mac('2c:9e:00:7a:26:38') -> proxy will be wrongly merged to mac('2c:9e:00:7a:26:38') -> proxy.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #339

Test Result

Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good to me! Thanks

@EkkoG
Copy link
Contributor

EkkoG commented Oct 23, 2024

以如下配置运行

mac('2c:9e:00:7a:26:38') -> direct
!mac('2c:9e:00:7a:26:38') -> direct
fallback: proxy

观察到国内网站正常打开,trace 日志级别,日志中没有任何网站被代理

测试通过

Thanks!

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 334cbd3 into main Oct 24, 2024
29 checks passed
@mzz2017 mzz2017 deleted the pr/gray/not-mac2 branch October 24, 2024 12:08
@dae-prow dae-prow bot mentioned this pull request Nov 3, 2024
@dae-prow dae-prow bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] !mac 判断异常
3 participants