optimize: reduce memory usage by reading kallsyms only in the trace command #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand lowers RSS usage from 196 MiB to 77 MiB using a minimal bootable config
jschwinger233
approved these changes
Nov 18, 2024
|
很喜欢这种以观测、profile来查找性能、内存问题的方式，谢谢！ |
|
Nice catch |
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, reading kallsyms during program loading causes unnecessary high memory usage, while kallsyms is only used in the trace command. Therefore, this patch changes it to initialize kallsyms before executing the trace command.
Checklist
Full Changelogs
Test Result
Configuration
Use
go tool pprof -http=:8080 http://localhost:12333/debug/pprof/heapto generate the flame graph.Screenshot
Lowers RSS usage from 194 MiB to 75 MiB.
Before:
After:
