Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add desktop file and icons #221

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

shenghuang147
Copy link
Contributor

@shenghuang147 shenghuang147 commented Aug 9, 2023

Background

Checklist

Full changelogs

  • [Implement ...]

Issue reference

Closes #[issue number]

Test Result

  • GNOME: image-20230809145555111
  • KDE: image-20230809143042997

@kunish
Copy link
Member

kunish commented Aug 9, 2023

Could you please add a screenshot to illustrate what this PR does?

@shenghuang147
Copy link
Contributor Author

What?

I added a Linux desktop file for the web panel, which allows users to launch the web panel from their desktop environment with a single click. The desktop file contains the name, icon, URL, and category of the web panel.

Why?

I added this feature because it improves the user experience and accessibility of the web panel. Users do not need to open a browser and type the URL of the web panel every time they want to use it. They can simply click on the desktop icon and the web panel will open in their default browser.

How?

I created a new file called daed.desktop in the install directory of the project. I used the Desktop Entry Specification to define the properties of the desktop file. I also added a new icons directory in the install directory, which contains the icon files for daed. I added multiple sizes of icons to ensure that they look good on different resolutions and scaling factors.

Testing?

I tested this feature on openSUSE Leap 15.5. I verified that the desktop file was installed correctly and that the web panel opened in the browser when I clicked on the icon. I also checked that the icon and name of the web panel were displayed correctly in the desktop environment.

Screenshots

Here are some screenshots of how the web panel looks like on different desktop environments:

  • GNOME: image-20230809145555111
  • KDE: image-20230809143042997

@kunish
Copy link
Member

kunish commented Aug 9, 2023

Well, your supplement far exceeded my expectations. Thank you so much for that. Now I have a good understanding about what this does. Amazing detail.

@kunish kunish merged commit b05d5db into daeuniverse:main Aug 9, 2023
@shenghuang147 shenghuang147 deleted the add_desktopFile branch November 5, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants