fix: Don't assume type antecedents too early #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s also some debugging code to evaluate how the new options differ from the previous.
This means that a type `T` can be passed as a `(0)` parameter even if `T` does not have an “zero bit pattern” value, as long as `T` does have _some_ compilable value. Remove HasZeroInitializer method Remove hasZeroInitializer parameter of TypeInitialization method.
Also, remove initializerIsKnown parameter of TypeInitialization().
# Conflicts: # Source/Dafny/DafnyAst.cs # Source/Dafny/Translator.cs # Test/allocated1/Allocated1.dfy.expect # Test/allocated1/AllocatedCommon.dfyi # Test/dafny0/GhostAutoInit.dfy # Test/dafny0/GhostAutoInit.dfy.expect # Test/dafny0/IteratorResolution.dfy.expect
davidcok
previously approved these changes
Jan 25, 2021
davidcok
approved these changes
Jan 25, 2021
This was referenced Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure the type antecedent of a variable is not assumed until after the variable has been assigned.
Depends on PR #1061.
Fixes #851
Make type antecedents conditional in well-formedness checks of constructs that introduce bound variables (assign-such-that statements, let-such-that expressions, forall/exists expressions, set/map comprehensions, lambda expressions).
Order assignments to definite-assignment trackers properly.
Restrict yield-parameters to auto-init types.