Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix workflow #59

Merged
merged 1 commit into from
May 6, 2022
Merged

ci: fix workflow #59

merged 1 commit into from
May 6, 2022

Conversation

crazy-max
Copy link
Contributor

Fixes issue in our e2e workflow:

 /opt/hostedtoolcache/dagger/0.2.9/x64/dagger do test
  failed to load plan: package "dagger.io" is incompatible with this version of dagger (requires 0.2.9 or newer). Run `dagger project update` to resolve this

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@TomChv TomChv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that should fix our CI.

/cc @shykes @jpadams Here we choose to run dagger project update before dagger do in the CI, that's related to our discussion.

However, I think it's mandatory for our CI since we tests multiple versions of dagger.

.github/workflows/ci.yml Show resolved Hide resolved
@TomChv TomChv requested a review from helderco May 6, 2022 10:36
@crazy-max crazy-max merged commit 6b63f0f into dagger:main May 6, 2022
@crazy-max crazy-max deleted the fix-ci-workflow branch May 6, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants