-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azidentity from 1.1.0 to 1.6.0 #16
chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azidentity from 1.1.0 to 1.6.0 #16
Conversation
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
* docs: Updates quickstart examples Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Fixed capitalization according to new style guide Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Updates examples Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Copy fix Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Added feedback Signed-off-by: Vikram Vaswani <vikram@dagger.io> --------- Signed-off-by: Vikram Vaswani <vikram@dagger.io>
* refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> refactor(sdk/rust): Into -> From Signed-off-by: kjuulh <contact@kjuulh.io> * chore: remove extra clone Signed-off-by: kjuulh <contact@kjuulh.io> * chore: fix spacing Signed-off-by: kjuulh <contact@kjuulh.io> * chore: revert allow warnigns Signed-off-by: kjuulh <contact@kjuulh.io> --------- Signed-off-by: kjuulh <contact@kjuulh.io>
…7038) * feat: use trait for Struct -> StructID instead of renaming objects Signed-off-by: kjuulh <contact@kjuulh.io> * chore: include for into id as well Signed-off-by: kjuulh <contact@kjuulh.io> * chore: remove extra linebreaks Signed-off-by: kjuulh <contact@kjuulh.io> * chore: fix line breaks Signed-off-by: kjuulh <contact@kjuulh.io> * refactor: remove direct dependency on ID Signed-off-by: kjuulh <contact@kjuulh.io> * chore: remove unused tests Signed-off-by: kjuulh <contact@kjuulh.io> --------- Signed-off-by: kjuulh <contact@kjuulh.io>
Signed-off-by: guangwu <guoguangwug@gmail.com>
Similar to Python SDK, uses introspection from `t.Dagger.instrospection` to generate schema file and mounting it to the container to generate code. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
This significantly improves initial directory upload speed, on my computer this goes from 4.8s to a much better 2.5s. *Ideally*, we could also avoid uploading the git directory. This is a bit of a pain *right now* though, so we don't do it! Signed-off-by: Justin Chadwell <me@jedevc.com>
* Upgrade `ex_doc` to latest version. * Update documentation on the `Dagger` module. * Remove `getting_started.livemd`, it's quite out-of-date. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
This is a very bad default to recommend - essentially this "de-secrets" a value, and this could then be leaked accidentally: - Potentially into OTEL spans - Potentially into cache keys - Potentially into engine logs We should recommend using `WithSecretVariable` instead, which is much better - then rely on the shell to do the interpolation, which avoids all of these problems. The secret scrubber will then guarantee that we don't secrets leaked into logs. Signed-off-by: Justin Chadwell <me@jedevc.com>
* fix gitlab before_script Fixes gitlab beore script by installing the Dagger CLI in a location that's availabe in the $PATH Signed-off-by: Marcos Nils <1578458+marcosnils@users.noreply.github.com>
* engine: remove ftp_proxy hack This removes the ftp_proxy hack we've had for a while for passing uncached metadata to containers (previously a lot, but recently trimmed down to just ServerID). Instead, we take advantage of the new custom executor added recently and use that to set the _DAGGER_SERVER_ID env var in containers. The plumbing passes the ServerID via job values, which get read by the solver's ResolveOp callback and used to tell the Executor for ExecOps which ServerID to set in the container. There's quite a bit more cleanup coming to everything involved here, but wanted to get this first step out since that hack, besides being annoying, was kind of dubious in nature and was a suspect in some strange behavior reported sometimes. Signed-off-by: Erik Sipsma <erik@sipsma.dev> * engine: remove apparently unused opTrackingGateway I don't see that this is actually used or ends up modifying anything. Suspect it's vestigial from pre-OTEL days so removing it. Signed-off-by: Erik Sipsma <erik@sipsma.dev> * engine: pass worker around instead of custom executor This fixes the problem in the previous commit where Dockerfiles with a syntax pragma hit the executor directly before a ServerID could be set. This wasn't the shortest fix, but it seems to be the best long term one. The end result is that the Worker provided to LLBSolvers is always scoped to the server, so we don't even need to be careful about ensuring the right executor is being used everywhere. It just will be now because it's the only executor available to buildkit internals we use. This required a few adjustments from the previous code: 1. The custom executor has been expanded to also be a custom worker. Fortunately, it almost entirely reuses functionality from upstream's base.Worker, so this doesn't another big chunk of code to maintain. 2. llbSolver is now created in each buildkit.Client and setup with a worker.Controller with the Worker scoped to the current ServerID. 3. Rather than passing the ServerID through job keys, we just pass the whole Worker and use that to resolve ops. 4. Some more general cleanup of worker initialization made possible by these changes. Signed-off-by: Erik Sipsma <erik@sipsma.dev> * backfill integ test coverage for dockerfile w/ syntax pragma Signed-off-by: Erik Sipsma <erik@sipsma.dev> * add comment pointing to original runc executor implementation Signed-off-by: Erik Sipsma <erik@sipsma.dev> --------- Signed-off-by: Erik Sipsma <erik@sipsma.dev>
* sdk(rust): use `load*FromID` in tests Use these newer methods instead of using `container` and `file` to load IDs, which is deprecated and *going to be removed soon*. Signed-off-by: Justin Chadwell <me@jedevc.com> * sdk(go): use load*FromID in tests Signed-off-by: Justin Chadwell <me@jedevc.com> * sdk(typescript): use load*FromID in tests Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: use load*FromID in tests Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Alex Suraci <alex@dagger.io>
* ci: exclude .git dir in ci build Previously, we were using this to generate a work-tree hash, so that new builds would have a different version tag, which helped to solve some weird caching issues with nested execs. However! A problem with this was that we needed to upload *the entire* git directory every time we built - which is an expensive operation, my .git directory for dagger/dagger is 147MB. Instead of relying on git for this, we can use the ID of the input directory! Because of our use of blob sources, a different ID represents a different directory. Additionally, we prefix these new builds with a special "dev-" string to specifically indicate that these are dev builds, with no specific version passed in - these aren't commit hashes, and cannot be treated as such. Signed-off-by: Justin Chadwell <me@jedevc.com> * ci: remove dependency on go sdk The only thing this was being used for here was the connect job - we can just use `--help` to get this info to sanity check it. Signed-off-by: Justin Chadwell <me@jedevc.com> * ci: run linting over ci itself Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: kpenfound <kyle@dagger.io>
With this typo, the yaml file was invalid and so the config failed to be applied. I *finally* found where you can check the validity of a dependabot config - see https://github.com/dagger/dagger/network/updates. Signed-off-by: Justin Chadwell <me@jedevc.com>
* chore: run dagger develop on typescript runtime Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: top-level dagger.gen.go should have correct imports Previously it wasn't, we were missing `telemetry` and `querybuilder`. And `go mod tidy` wouldn't *always* seem to pick it up, which is a bit of a pain. Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: avoid overwriting go mod/sum files on module generation This is a bit of a mess - but essentially, what *was* happening was that we had some very strange issues with go.mod generation. When generating code, we had a couple of issues: - If we were generating on top of an existing go.{mod,sum}, we were essentially replacing its contents, and then relying on `go mod tidy` to give reasonable results - however, this meant that explicitly installed dependencies were getting lost, and that we were losing the pins in the sum file. - Additionally, if we were generating a new `dagger` subfolder in an existing monorepo, we were overriding the previous go.{mod,sum} with dagger's go.{mod,sum}, and then relying on `go mod tidy` to find all the user dependencies. The main issue with the above is that we were replacing contents of these important dependency files in weird ways that make go modules much more difficult to consume, especially in monorepos. To fix these issues, we heavily rework the logic - we explicitly find the correct go.mod file we want to work on, and then apply *the same* processing everywhere. This processing involves checking go versions, adding dependencies that aren't present, merging go.sum values, etc. However - in doing this, something becomes quite apparent - we were relying on some weird undefined behavior in the Go SDK. Generally the structure of the paths passed in was that `ModuleContextPath` was a parent to `OutputDir`, and we wouldn't modify anything outside `OutputDir`. But consider, if the output directory is `./dagger` (the default), then we may need to modify the top-level `./go.mod` (that isn't in `OutputDir`). We technically *were* doing this, but by using `go mod tidy` to get it to do this magically - but as mentioned above, we need to avoid this automatic behavior, and do some better merging ourselves. To resolve this, `OutputDir` becomes the top-level, while `ModulePath` becomes a relative sub-path in `OutputDir` that the module can be found at (in the above, that's `./dagger`). This is why this patch also needs to touch the Typescript runtime files, since we change the format of the arguments to use this new format (also the Typescript generation was confusing here, so picked up a couple of refactors as well along the way). Signed-off-by: Justin Chadwell <me@jedevc.com> * tests: fix incorrect go.{mod,work} tests - The `go.mod` test was incorrect because prior to the commit before this one, we were actually generating a `go.mod` in the child. This was *hard* to notice, because essentially, there was a weird disparity between having a `go.mod` and having a `go.mod` *and* a `main.go` in the top-level (since `loadPackage` fails on the former, but succeeds on the latter). The test is modified to ensure we can catch this in the future, and the prior commit makes sure that this weird disparity is removed. - The `go.work` tests were incorrect because we shouldn't have been putting `go.mod`s in the children (the same `loadPackage` issue as above). Each of these test cases should only have *one* module, so we alter the tests to check for this. Signed-off-by: Justin Chadwell <me@jedevc.com> * review comments Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
* chore: fix some doc comments for daqgl to match Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: remove some unused parameters And also enable a linter to catch these in the future. `unparam` seems to be optimized more heavily to avoid false positives, and is significantly better at not bringing up weird interface cases that revive seems to love. Signed-off-by: Justin Chadwell <me@jedevc.com> * fixups Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
* cli: visual cue for required flags Append [required] to flags that are marked as required. As proposed by Helder, this follows the behavior of Typer: https://typer.tiangolo.com/tutorial/options/required/ Signed-off-by: grouville <guillaume@dagger.io> * Rename template function to be more descriptive Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> * Simplify flagset merge Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> * Replace clone with mutation This preserves the `flag.Annotations` map, which is needed for validation. Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> * Replace string key with const The rest wasn't wrong but follows how `Command.ValidateRequiredFlags` handles these flags. Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> * Add change log Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> --------- Signed-off-by: grouville <guillaume@dagger.io> Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> Co-authored-by: grouville <guillaume@dagger.io> Co-authored-by: Helder Correia <174525+helderco@users.noreply.github.com>
* ci: Add Wolfi base image option Signed-off-by: Adrian Mouat <adrian@chainguard.dev> * Simplify apk command. Signed-off-by: Adrian Mouat <adrian@chainguard.dev> * nit: use const for Wolfi image reference. Signed-off-by: Adrian Mouat <adrian@chainguard.dev> * Plumb through setting base image. Use `engine with-base image="wolfi"` etc Also fix typo in error return Signed-off-by: Adrian Mouat <adrian@chainguard.dev> * ci: rework gpusupport into a common WithBase function And also update mage calls to get the right base image, so we can definitely publish. Signed-off-by: Justin Chadwell <me@jedevc.com> * ci: simplify gpu support checks into switches Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Adrian Mouat <adrian@chainguard.dev> Signed-off-by: Justin Chadwell <me@jedevc.com> Co-authored-by: Justin Chadwell <me@jedevc.com>
Goreleaser needs this :( Signed-off-by: Justin Chadwell <me@jedevc.com>
* docs: Adds information on Dagger Cloud cache Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Updated note Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Added link Signed-off-by: Vikram Vaswani <vikram@dagger.io> --------- Signed-off-by: Vikram Vaswani <vikram@dagger.io>
* chore: update internal tooling to v0.11.2 Signed-off-by: Justin Chadwell <me@jedevc.com> * docs: update docs to refer to newest v0.11.2 release Signed-off-by: Justin Chadwell <me@jedevc.com> * ci: update to install dagger cli v0.11.2 Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: update RELEASING guide Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: Add Helm releasing instructions to RELEASING.md Also prepare the Helm chart for release right after this gets merged. Also run `go mod tidy` after rebasing. Signed-off-by: Gerhard Lazu <gerhard@dagger.io> --------- Signed-off-by: Justin Chadwell <me@jedevc.com> Signed-off-by: Gerhard Lazu <gerhard@dagger.io> Co-authored-by: Gerhard Lazu <gerhard@dagger.io>
* cli: conventionalize on <command> in cmd.Use Unifies the DX around usage across all commands. The convention follows the standards (gh / git CLIs) as well as the defaults from cobra. The grammar is as follow: - []: optional - <>: user input, when argument is not optional, to differenciate with static args - ...: one or more This commit applies it everywhere and unifies according to this grammar. Signed-off-by: grouville <guillaume@dagger.io> * Fix incorrections Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> * Remove second use line Sometimes a subcommand is required (`dagger call`), and other times it's optional (`dagger config`). Best make it explicit in `Use`. Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> * Fix required mark when flag has no description Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> --------- Signed-off-by: grouville <guillaume@dagger.io> Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> Co-authored-by: grouville <guillaume@dagger.io> Co-authored-by: Helder Correia <174525+helderco@users.noreply.github.com>
Upgrading the Erlang/OTP to fix Erlang erlang/otp#8238 bug. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
…ns" in `dagger call --help` (#7286) * cli: use "functions" and "arguments" instead of "commands" and "options" in `dagger call` Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> * Add change log Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> --------- Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Alex Suraci <alex@dagger.io>
* docs: Remove numeric ids Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Update integrations pages Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Fix link Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Update admin manual pages Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Fix link Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Update redirect rule Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Update user manual pages Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Updated user manual pages Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Update user manual Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Move Google Cloud Run guide to integrations section Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Removed guides component Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Update GCR integration page Signed-off-by: Vikram Vaswani <vikram@dagger.io> * fix: docs linter Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Vikram Vaswani <vikram@dagger.io> Signed-off-by: Justin Chadwell <me@jedevc.com> Co-authored-by: Justin Chadwell <me@jedevc.com>
This will allow users to workaround the lack of pinning of tsx in previous engine releases until our next release. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
* hack: add legacy label conversion for old clients This allows old clients like dagger v0.10.3 to still connect to and use dagger engine v0.11.0. While this *isn't* a strict requirement, it's nice to not break this if we don't have to, and based on a couple tests, it seems like this was the only blocker for that. This is needed so we can determine legacy client versions. Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: ensure client fails out when session call fails If the main session call that was supposed to register the server fails out, there can be no recovery! No number of retries will help, so we should cancel the context. Additionally, we can manipulate the error handling logic to ensure that when the context is cancelled for this reason, that we return a *relevant* error - we can just take the last error, this is good enough. Signed-off-by: Justin Chadwell <me@jedevc.com> * feat: introduce minimum versioning requirements With this change, we finally introduce minimum version requirements, in two parts: - Clients can enforce constraints on the minimum required server version - Servers can enforce constraints on the minimum required client version Doing this is a bit challenging. Both sides need to know what the other side's version is - thankfully, we've been doing this for a *while*. - The client can get the server version through the Buildkit client.Info call (where we've been attaching this data since v0.9.0). - The server can get the client version info through old telemetry labels (after explicitly handling old-style telemetry labels), or through a newly introduced ClientMetadata field. With this new data, we can enforce version constraints! However, in the case of the server-side version constraints for the client, we hit a slightly weird case - the client got stuck in a retry loop when the Session failed to start. This isn't quite right behavior anyways (any error from the main Session call that starts a server wouldn't cause an immediate failure), it just appeared when we try and display version constraints. We can easily fix this going forwards - on older clients, we just get the failure logs, the retry will still occur, and we fail about 5 minutes. Signed-off-by: Justin Chadwell <me@jedevc.com> * tests: add test for checking version compatibility Signed-off-by: Justin Chadwell <me@jedevc.com> * docs: add backwards compatability notes to RELEASING Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
* chore: add DAGGER_COMMIT option to install.sh This allows installing an arbitrary commit from main, to make it easier to install versions from main for testing. Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: ensure install.ps1 keeps working on windows Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
* chore: update alpine base to 3.20 Signed-off-by: Justin Chadwell <me@jedevc.com> * tests: don't require specific squid proxy version Signed-off-by: Justin Chadwell <me@jedevc.com> * ci: bump go to 1.22.4 Also, we can remove the runc hack - go 1.22.4 includes a backported fix for the pthreads issue that upstream was encountering. Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
While we are keeping this default so that we don't break existing users, setting this value is something that we want to move away from. The problem is that this setting limits how many operations can run in parallel. It is still possible for a single operation to max out all available cores. It is also known for a value of `2` to cause deadlocks, i.e. dagger/dagger#6894 For now, we just allow this to be disabled with either `--set engine.args=''` or by explicitly setting this value to an empty list. This started as dagger/dagger#7395 which turned out to be too big of a change. We since scaled back the initial ambition & are taking a smaller step towards eventually phasing this out. FWIW, all the Dagger Engines that we run inside the Dagger infra do not use the `--oci-max-parallelism` option. This also removes the option from tekton-dagger-task docs example. Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
This has been reported to happen intermittently by a few users. The error originates from gqlgen and suggests that something in the http request is unhandled; it basically tries to find a matching pattern for gql requests based on http method and some headers. It's unclear how this could happen only occasionally and I've never seen this myself yet, so I think our best bet is to log the parts of the request checked by gqlgen and wait for it to get hit again. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Bumps [rustls](https://github.com/rustls/rustls) from 0.21.10 to 0.21.12. - [Release notes](https://github.com/rustls/rustls/releases) - [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md) - [Commits](rustls/rustls@v/0.21.10...v/0.21.12) --- updated-dependencies: - dependency-name: rustls dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* close service logs too Signed-off-by: Alex Suraci <alex@dagger.io> * telemetry: fix tunnel log draining and other missing closes I was still having to wait 5 minutes for OTEL logs to drain on some test runs that involved service tunneling. I believe there was a race condition where the tunnel code could end up writing logs after they were closed, which seems to create a leak and cause us to have to wait 5 minutes before a timeout is hit. I also saw a few other place otel logs were created and not closed, so added a close there too. Signed-off-by: Erik Sipsma <erik@sipsma.dev> * unify on slog, focus draining on stdio use case * SpanLogger no longer writes to stdio streams, since it's unclear at each logging site who has responsibility to Close(); this way no one does. * switch last few holdouts to slog - for better or for worse, we should be consistent and iterate. We've started using slog for client-side logs, so we might as well adopt them server-side too. Signed-off-by: Alex Suraci <alex@dagger.io> * propagate debug/no-color mode to server uses otel baggage, which I thankfully already went through the trouble of propagating, and hadn't used yet. neat! Signed-off-by: Alex Suraci <alex@dagger.io> --------- Signed-off-by: Alex Suraci <alex@dagger.io> Signed-off-by: Erik Sipsma <erik@sipsma.dev> Co-authored-by: Erik Sipsma <erik@sipsma.dev>
When an exec fails due to context canceled, we were dropping the cancelation error and just returning the exec error. I believe this got fat-fingered while updating the code from upstream to use fmt.Errorf instead of github.com/pkg/errors. It's not clear if this is really meaningful, but noticed it changed while attempting to debug occurances of "exit code 137" in our CI, which plausibly could be related to all of this. It's possible there's calling code that tries to handle cancelation with errors.Is, which this would have broken. This is purely hypothetical at this point though. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
There was a race condition where contexts get canceled after a job is sent to the netns worker but before the result got read. This caused runInNetNS to exit (due to canceled context) but the result chan to never be read from. It was crucially an unbuffered chan, which resulted in the worker never being able to exit and the whole container cleanup to block indefinitely. The fix here is just to make that chan buffered with a size of 1 so that the worker doesn't ever get blocked trying to write to it. There's a few other related changes of making some other chans buffered and explicitly closing them with a defer (to handle panic cases) which aren't needed to fix this issue but seemed worth tidying up now. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
* fix: ensure nested frontend builds get secret translation When doing a nested frontend build - i.e. when dockerfile.v0 calls gateway.v0 (triggered by a syntax directive), we need to ensure that the second frontend gets the same secret translation as each prior layer. To do this, we heavily refactor the filtering gateway and essentially have it pass itself into the frontend Solve - this propagates the filtering all the way down, so secrets can be correctly accessed. Signed-off-by: Justin Chadwell <me@jedevc.com> * tests: add test for remote frontend Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: add changelog Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
The tsx issue has been fixed so this isn't needed anymore. Worst case if something else pops up this SDK would still be usable by it's git commit ref, so may as well remove it now. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
* ci: upgrade golangci lint to v1.59 Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: fix linting issues Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
* fix(ts-sdk) rollback to npm to ignore packageManager field #7096 introduced a regression by using `yarn install --production`. If the field `packagaManager` is set, it might lead to failure because yarn post v1.22.11 doesn't support the `--production` flag anymore, it has been removed in favor of `yarn workspaces focus --production`. However, depending on the yarn major version (v2, v3, v4), the options are different but also the results and the way they handle subdependencies. It seems `npm` is the only package manager that actually force install all the sub dependencies, which ensure the TS SDK runtime properly works. Signed-off-by: Tom Chauveau <tom@epitech.eu> * chore: add release note Signed-off-by: Tom Chauveau <tom@epitech.eu> * feat: move corepack init inside SDK installation Signed-off-by: Tom Chauveau <tom@epitech.eu> * fix: remove `--production` on user's install deps Signed-off-by: Tom Chauveau <tom@epitech.eu> --------- Signed-off-by: Tom Chauveau <tom@epitech.eu> Co-authored-by: Tom Chauveau <tom@epitech.eu>
* ci: enable best-effort cache reuse for nested engines We were previously always putting a random id in the cache volume used for engines created in various CI functions, which meant none of them ever had any local cache. The main reason was that two engines can't use the same local cache at the same time. We can't lift that limitation, but by using the engine version and private cache mounts we can get *best effort* re-use of these cache volumes, which is a simple enough performance improvement for some cases that we may as well take it. Signed-off-by: Erik Sipsma <erik@sipsma.dev> * ci: make engine service version optional Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Erik Sipsma <erik@sipsma.dev> Signed-off-by: Justin Chadwell <me@jedevc.com> Co-authored-by: Justin Chadwell <me@jedevc.com>
* fix(sdk/elixir): add :inets to :extra_applications `:inets` requires to start before using the SDK because of `:httpc` module. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com> * Add changie log Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com> --------- Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
* fix: don't hide quick top-level progress rows Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: always simplify internal operations on render In particular, this ensures that `blob` operations are always simplified to their source, which hugely helps to improve readability. Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: add empty line after progress before result Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: omit return type on DONE Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: extract prefix generation Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: refactor logs views into a panel Signed-off-by: Justin Chadwell <me@jedevc.com> * feat: rework cloud progress printing For pretty progress, we add a new little message panel at the bottom containing a "Full trace at ..." message. For plain progress, in addition to the above, we also add a little fake virtual log to the "connecting to engine" span, so that it's available from the very start of the trace. Signed-off-by: Justin Chadwell <me@jedevc.com> * tests: fixup some failing tests Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: move msgs panel to top Signed-off-by: Justin Chadwell <me@jedevc.com> * fix: failing version test Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Justin Chadwell <me@jedevc.com>
we're changing the default minConnectTimeout and backoff settings since in some cases, the `connect` happens before the engine is ready to accept connections, causing the client to wait for the default minConnectTimeout (20s) before retrying. This causes very long connection times when the engine is not ready to accept connections. fixes #7599 Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
* sdk: Bump engine dependency to v0.11.7 Signed-off-by: Dagger CI <hello@dagger.io> * chore: add sdk release notes for v0.11.7 Signed-off-by: Justin Chadwell <me@jedevc.com> * chore: bump helm dagger version to v0.11.7 Signed-off-by: Justin Chadwell <me@jedevc.com> * docs: bump dagger version to v0.11.7 Signed-off-by: Justin Chadwell <me@jedevc.com> --------- Signed-off-by: Dagger CI <hello@dagger.io> Signed-off-by: Justin Chadwell <me@jedevc.com> Co-authored-by: Dagger CI <hello@dagger.io> Co-authored-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Bumps [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) from 1.1.0 to 1.6.0. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@v1.1...sdk/azcore/v1.6.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
The following labels could not be found: |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/Azure/azure-sdk-for-go/sdk/azidentity from 1.1.0 to 1.6.0.
Release notes
Sourced from github.com/Azure/azure-sdk-for-go/sdk/azidentity's releases.
... (truncated)
Commits
36f766d
add sdk/resourcemanager/cosmos/armcosmos live test (#20705)c005ed6
sdk/resourcemanager/network/armnetwork live test (#20331)5fa7df4
add sdk/resourcemanager/compute/armcompute live test (#20048)0d22aed
add sdk/resourcemanager/eventhub/armeventhub live test (#20686)2a8d96d
add sdk/resourcemanager/postgresql/armpostgresql live test (#20685)b2cddab
[Release] sdk/resourcemanager/paloaltonetworksngfw/armpanngfw/0.1.0 (#20437)ed7f3c7
Fix azidentity troubleshooting guide link (#20736)6dfd0cb
[azeventhubs] Fixing checkpoint store race condition (#20727)745d967
pass along the artifact name so we can override it later (#20732)20b4dd8
Update changelog with latest features (#20730)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.