-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 48 removes SVGGraphicsElement.getTransformToElement() #202
Comments
@rbojha, can you post the polyfill you are using? Are you using the same polyfill that JointJS posted? |
yes @robhobbes, we are using the same polyfill as JointJs Team posted..
|
This should be fixed in 0.4.13 (verified on Chrome 48). If you see any issues please open a new issue. Thanks. |
Apparently chrome removed SVGElement.prototype.getTransformToElement, which is used by dagre-d3 when creating edges. This commit is taken from a fix in the main repo: dagrejs@1ef067f dagrejs#202
Apparently chrome removed `SVGElement.prototype.getTransformToElement`, which is used by our JS library dagre-d3 when creating edges. The real diff can be found here: andrewor14/dagre-d3@7d6c000, which is taken from the fix in the main repo: dagrejs/dagre-d3@1ef067f Upstream issue: dagrejs/dagre-d3#202 Author: Andrew Or <andrew@databricks.com> Closes #10986 from andrewor14/fix-dag-viz. (cherry picked from commit 70e69fc) Signed-off-by: Andrew Or <andrew@databricks.com>
Apparently chrome removed `SVGElement.prototype.getTransformToElement`, which is used by our JS library dagre-d3 when creating edges. The real diff can be found here: andrewor14/dagre-d3@7d6c000, which is taken from the fix in the main repo: dagrejs/dagre-d3@1ef067f Upstream issue: dagrejs/dagre-d3#202 Author: Andrew Or <andrew@databricks.com> Closes #10986 from andrewor14/fix-dag-viz. (cherry picked from commit 70e69fc) Signed-off-by: Andrew Or <andrew@databricks.com>
Apparently chrome removed `SVGElement.prototype.getTransformToElement`, which is used by our JS library dagre-d3 when creating edges. The real diff can be found here: andrewor14/dagre-d3@7d6c000, which is taken from the fix in the main repo: dagrejs/dagre-d3@1ef067f Upstream issue: dagrejs/dagre-d3#202 Author: Andrew Or <andrew@databricks.com> Closes #10986 from andrewor14/fix-dag-viz. (cherry picked from commit 70e69fc) Signed-off-by: Andrew Or <andrew@databricks.com>
Apparently chrome removed `SVGElement.prototype.getTransformToElement`, which is used by our JS library dagre-d3 when creating edges. The real diff can be found here: andrewor14/dagre-d3@7d6c000, which is taken from the fix in the main repo: dagrejs/dagre-d3@1ef067f Upstream issue: dagrejs/dagre-d3#202 Author: Andrew Or <andrew@databricks.com> Closes #10986 from andrewor14/fix-dag-viz.
Wow so the justification for removing this from Chrome was it is too difficult to fix the issues? That sounds like a crappy reason what am I missing? |
The upstream fix is dagrejs/dagre-d3#202
Some notes for people encountering this issue: I also encountered this issue in v0.4.10, and I tried v0.4.13 and found the dagre-d3/dist/dagre-d3.core.js is missing from that version. It turns out that v0.4.17 works for the current version of Chrome. |
Apparently chrome removed `SVGElement.prototype.getTransformToElement`, which is used by our JS library dagre-d3 when creating edges. The real diff can be found here: andrewor14/dagre-d3@7d6c000, which is taken from the fix in the main repo: dagrejs/dagre-d3@1ef067f Upstream issue: dagrejs/dagre-d3#202 Author: Andrew Or <andrew@databricks.com> Closes apache#10986 from andrewor14/fix-dag-viz. (cherry picked from commit 70e69fc) Signed-off-by: Andrew Or <andrew@databricks.com>
dagrejs/dagre-d3#202 Change-Id: Ic9450e8eef55af2778e2cea571f6e174841d5f43
dagrejs/dagre-d3#202 > Chrome 48 removes SVGElement.prototype.getTransformToElement which is used when creating edges
After deploying this fix I notice these warnings suggesting tooltips will break shortly:
|
@jrgleason if you're interested, it's been removed from the SVG spec, it's not just Chrome removing a feature. |
Unfortunately the most recent beta version of chrome (48.0.2564.23) removes
SVGElement.prototype.getTransformToElement
which is used when creating edges.The motivation behind removing this feature can be found here with the actual Google Chrome issue tracking this here
Therefore using
dagre-d3
in this latest beta version of Chrome throws errors like:As suggested by the JointJS team this function can be poly-filled where it is required. We are working around this locally with a polyfil for now, but it clearly would be better for
dagre-d3
to centralise a fix (polyfil or otherwise) so that everyone using Chrome 48 can benefit.Any thoughts on how best to fix this in
dagre-d3
?The text was updated successfully, but these errors were encountered: