-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for manual ranking #271
base: master
Are you sure you want to change the base?
Conversation
@anyazz hi,do you have any example?I am still have problem with rank field |
Can this please be merged with dagre-d3? I require this function... |
Dear @anyazz I would really be ver happy, if it was possible to give ranks to nodes! Thanks! |
@anyazz hello, again. Is it possible to contact you somehow? |
@lutzroeder @anyazz What needs to be done to advance this to a point where it can be merged? |
@lutzroeder not sure if you are the maintainer of dagre, but since you seem to be making most recent commits in dagre-d3, do you think this can be merged and contributed to dagre-d3? I'm looking into adding rank support. Thanks! |
@lutzroeder @anyazz Hey is there any progress on this PR? It would solve a major layout issue for me, and apparently for the author of #289 as well. |
@anyazz ranking is not working. |
Support for syncing the rank of some elements is the only thing stopping dagre for being great for family trees. You want relations between parters to be horizontal and between parent/child to be vertical. Setting the same rank on partners fixes this. Currently the rank attribute on nodes seems to be ignored by dagre. |
Hello Guys, what can i do to get this branch merged ? what are the current issues that needs fixing? i really need this feature and i have some spare time so i might be able to help getting it shipped ... |
@el3ctrician I've tried running this branch locally, and it doesn't seem to do anything. So I'm not sure what can be done. |
So I also used this fix and came across the same problem you are describing and apparently it's not a problem with the manual ranks but with drawing edges between nodes of the same rank because that seems to not be possible at all. If you try the interactive demo they offer in their wiki then you can also see that whenever you try to draw an edge between nodes of the same rank then one of the nodes will drop/increase in rank automatically. Since with this change the rank is manually set then it will crash and you'll get the error you are seeing |
Hi, do you have any idea whether this can be merged? I need this functionality as well, and I do not need lines between the same rank nodes, so I should be not affected with the bug you mentioned earlier. |
Hey, I'm just adding another comment with "I would love to have this available". Is there anything we can do to help? |
This adds an option for g.graph().ranker to be a manually specified ranking function and makes rank a node attribute. Would solve issues like #243 and allow temporary fixes for issues like #150.