New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent `Maximum call stack exceeded` by apply args to `Math.min`, `Math.max` in chunks #447

Merged

rustedgrail merged 2 commits into dagrejs:master from datafold:apply-args-by-chunks

Aug 15, 2024

Contributor

sklinov commented Jul 31, 2024

Fixing the issue when Maximum call stack exceeded error is thrown on calculation of Math.min(...) and Math.max(...), due to limitations to the number of arguments that could be passed to the function.
(More context here: https://stackoverflow.com/questions/22747068/is-there-a-max-number-of-arguments-javascript-functions-can-accept).

Now, it's not recursive and limited to 65535 * 65535 = 4 294 836 225 arguments, but this can be improved in the future.

sklinov added 2 commits

July 31, 2024 12:03


          Update maxRank to workaround limit on number of arguments of function

a73e2cc


          Fix all Math.min() and Math.max() with unknown number of arguments

fee1acf

rustedgrail merged commit 71a8f04 into dagrejs:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet