fix(dagster_airbyte): Add new normalization config check #14174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nina-j
changed the title
Fixes dagster-io#13524. The Airbyte API changed source of truth for normalization availability in airbytehq/airbyte#21005. This commit adds an additional check for normalization configuration in `does_dest_support_normalization`. The current check is kept to ensure backward compatibility - thus, if any of the checks are true, the function returns true.
nina-j
changed the title
nina-j
force-pushed
the
fix-airbyte-dest-normalization
branch
from
3cce17c to
638a11d
Compare
|
Thanks for the PR, this looks reasonable and I'm running our CI on it. |
|
Alright this looks great, thanks and merging! |
|
Thank you! 😄 |
salazarm
pushed a commit
that referenced
this pull request
May 10, 2023
## Summary & Motivation The Airbyte API changed source of truth for normalization availability in airbytehq/airbyte#21005. This commit adds an additional check for normalization configuration in `does_dest_support_normalization`. The current check is kept to ensure backward compatibility - thus, if any of the checks are true, the function returns true. Fixes #13524. ## How I Tested These Changes I ran the test suite for the `dagster_airbyte` module and added tests that cover my changes. Co-authored-by: Nina Jensen <nije@boozt.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The Airbyte API changed source of truth for normalization availability in airbytehq/airbyte#21005. This commit adds an additional check for normalization configuration in
does_dest_support_normalization. The current check is kept to ensure backward compatibility - thus, if any of the checks are true, the function returns true.Fixes #13524.
How I Tested These Changes
I ran the test suite for the
dagster_airbytemodule and added tests that cover my changes.