Add securityContext to daemon initContainer (#16092) #16095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alangenfeld please review :) |
alangenfeld
approved these changes
Aug 25, 2023
|
nice, will merge after test run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
In the deployment-daemon.yaml a initContainer is created for every element of userDeployment.deployments
This is not inheriting the (container-)security context Values.dagsterDaemon.securityContext like the check-db-ready initContainer or the actual daemon.
With Pod Security restrictions in place there is no way to get past the admission hook
How I tested
I tested building the helm chart und submitting it and it renders and starts. This is my first Contribution, and I followed all Guidelines I could find (wonderful template btw). If there is a formal issue, please don't hesitate to point to hit. :)