(ui) Improve UI when using long values in params #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dagu-org#594 In the case of long params, the dialogue box is unusable. This change limits each arg to one line.
Using uninterpolated args on the show page will improve rendering when long arguments are used. Users remain able to understand their commands by seeing the params attached to each execution.
|
A similar experience exists on the dags view page: (http://localhost:8080/dags/issue-594) if using those args in the command: 
My thought there is:
Here's what it would look like instead: If there's a simpler way to get access to the original and uninterpolated command inside NodeStatusTableRow, please instruct me or feel free to directly edit the PR 🙏. Thank you for taking the time to consider and review these contributions @yohamta. I'm not attached to the implementation I coded beyond wishing to improve the UX for this case, without negatively affecting the UX for other cases. I'm open to other solutions that may be clearer to you because of your experience building this project.
|
zph
changed the title
|
One question, what is
|
|
🙂 my name and also the Z in my GitHub initials
…On Fri, Jun 28, 2024, at 08:52, Yota Hamada wrote:
One question, what is `Zander` by the way? 🙂
> • Zander
—
Reply to this email directly, view it on GitHub <#596 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH2UGHLM24YFUB27NM6ZF3ZJWBCLAVCNFSM6AAAAABKB22KH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGIYTQNJWGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
Zander
GH: @zph || https://blog.xargs.io
|
|
Oh, I see! sorry for the strange question 😅 |
|
No problem! It was polite and inquisitive
…On Fri, Jun 28, 2024, at 20:00, Yota Hamada wrote:
Oh, I see! sorry for the strange question 😅
—
Reply to this email directly, view it on GitHub <#596 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH2UGDFK2I3MLYYQUZ47H3ZJYPMLAVCNFSM6AAAAABKB22KH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXHA3DSNRSGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
Zander
GH: @zph || https://blog.xargs.io
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #594
Screenshots of before and after when using the same dag
In the case of long params, the dialogue box is unusable and this is part of a fix to improve their usability.
This change limits each arg to one line and the params remain scrollable to allow for user editing.
For discussion:
I'm not stuck on this solution but I do see it re-enabling usability of the Start dialogue for cases where the params's value is long.