Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log not loading when '&' in name #651

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

Lucaslah
Copy link
Contributor

@Lucaslah Lucaslah commented Aug 7, 2024

Fixes an issue where if a step has the '&' character in its name, the step log will not load.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.16%. Comparing base (d81fb49) to head (ba00d90).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          53       53           
  Lines        4156     4156           
=======================================
  Hits         2750     2750           
  Misses       1186     1186           
  Partials      220      220           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81fb49...ba00d90. Read the comment docs.

Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨LGTM✨✨✨, thank you so much for the great contribution!

@yohamta yohamta merged commit 2e422ed into dagu-org:main Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants