-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE[578] Add json bool configuration option to HTTP executor #656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking great! Just left a comment for a minor change.
internal/dag/executor/http.go
Outdated
type httpJSONResult struct { | ||
StatusCode int `json:"status_code"` | ||
Headers map[string][]string `json:"headers"` | ||
Body map[string]any `json:"body"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider changing the Body
type to any
because valid JSON can be arrays, primitives, or null, not just objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I didn't consider it thoroughly. Thank you for the reminder.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 53 53
Lines 4156 4156
=======================================
Hits 2750 2750
Misses 1186 1186
Partials 220 220 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨✨✨LGTM✨✨🚀, thank you very much!
HTTP executor supports writing the HTTP response in JSON format.
HTTP executor config
Result