Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests #663

Merged
merged 15 commits into from
Aug 14, 2024
Merged

Additional tests #663

merged 15 commits into from
Aug 14, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 12, 2024

No description provided.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 54.08805% with 73 lines in your changes missing coverage. Please review.

Project coverage is 65.08%. Comparing base (807d3f9) to head (45126d3).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/dag/scheduler/node.go 63.41% 11 Missing and 4 partials ⚠️
internal/logger/logger.go 0.00% 14 Missing ⚠️
internal/persistence/model/node.go 0.00% 8 Missing ⚠️
cmd/restart.go 50.00% 7 Missing ⚠️
cmd/retry.go 53.84% 6 Missing ⚠️
cmd/dry.go 58.33% 5 Missing ⚠️
cmd/start.go 58.33% 5 Missing ⚠️
internal/logger/file.go 85.18% 2 Missing and 2 partials ⚠️
cmd/start_all.go 0.00% 2 Missing ⚠️
cmd/status.go 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   66.37%   65.08%   -1.30%     
==========================================
  Files          53       53              
  Lines        4173     4273     +100     
==========================================
+ Hits         2770     2781      +11     
- Misses       1183     1263      +80     
- Partials      220      229       +9     
Files Coverage Δ
internal/agent/reporter.go 90.32% <100.00%> (ø)
internal/dag/builder.go 78.52% <100.00%> (ø)
internal/dag/scheduler/graph.go 69.93% <100.00%> (ø)
internal/dag/scheduler/scheduler.go 88.13% <100.00%> (ø)
cmd/scheduler.go 65.71% <0.00%> (+1.82%) ⬆️
cmd/server.go 87.50% <0.00%> (+2.65%) ⬆️
internal/persistence/local/dag_store.go 0.00% <0.00%> (ø)
cmd/start_all.go 32.50% <0.00%> (+1.54%) ⬆️
cmd/status.go 73.91% <0.00%> (+5.91%) ⬆️
cmd/stop.go 58.82% <0.00%> (+3.26%) ⬆️
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2a817...45126d3. Read the comment docs.

@yohamta yohamta merged commit 765fa19 into main Aug 14, 2024
3 checks passed
@yohamta yohamta deleted the additional-tests branch August 14, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant