Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#653] Add Pagination Parameters to DAG List API to limit the response #664

Merged
merged 14 commits into from
Aug 14, 2024

Conversation

halalala222
Copy link
Contributor

Bug Fix:

  1. the logic handling for entering an empty name in the New DAG button.
    image
    image
    After:
    image
    image
    image
    image
  2. the logic handling for no results found in search page.
    img_v2_211cf4eb-d24e-4f3e-9da4-5e0e6d3b4e9l
    After:
    img_v2_d1c92062-e126-4200-ab57-72aae4b8dbdl

Enhancement Compelete

  1. DAG list add pagination
    total DAGS :
    pkx8ZXfSPS
    for test limit is 5
    DwpeQGpZLA
    Mg3SPVMkxA
    hHovDHwPCC
    v20BSCj37I
    sK6tGPXVwl
    NpfusVatTT
    iSLenQeRHx
    Ix1AiOquYp
    SJmZ18KMSi
    c3jnJhOOeA
    DBwWQU7YRQ
    search:
    VNEGVpgTPC

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 23.46939% with 75 lines in your changes missing coverage. Please review.

Project coverage is 65.37%. Comparing base (a10fff5) to head (ece0d45).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/persistence/local/dag_store.go 0.00% 71 Missing ⚠️
internal/client/client.go 85.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   66.16%   65.37%   -0.80%     
==========================================
  Files          53       53              
  Lines        4156     4269     +113     
==========================================
+ Hits         2750     2791      +41     
- Misses       1186     1256      +70     
- Partials      220      222       +2     
Files Coverage Δ
internal/client/interface.go 100.00% <ø> (ø)
internal/client/client.go 75.23% <85.18%> (+1.15%) ⬆️
internal/persistence/local/dag_store.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10fff5...ece0d45. Read the comment docs.

Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨LGTM✨✨✨🚀🚀🚀, thank you very much for implementing this and all the hard work! Really appreciate it!

@yohamta yohamta merged commit af2a817 into dagu-org:main Aug 14, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants