Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue #672

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Fix build issue #672

merged 4 commits into from
Aug 28, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 28, 2024

No description provided.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 64.68%. Comparing base (f1bfcdd) to head (462aa0f).

Files Patch % Lines
internal/dag/context.go 0.00% 19 Missing ⚠️
internal/dag/scheduler/scheduler.go 62.50% 1 Missing and 2 partials ⚠️
internal/dag/scheduler/node.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   64.72%   64.68%   -0.05%     
==========================================
  Files          53       53              
  Lines        4306     4315       +9     
==========================================
+ Hits         2787     2791       +4     
- Misses       1263     1269       +6     
+ Partials      256      255       -1     
Files Coverage Δ
internal/agent/agent.go 73.79% <100.00%> (+0.84%) ⬆️
internal/dag/scheduler/node.go 84.49% <88.23%> (+0.24%) ⬆️
internal/dag/scheduler/scheduler.go 87.66% <62.50%> (-0.47%) ⬇️
internal/dag/context.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bfcdd...462aa0f. Read the comment docs.

@yohamta yohamta merged commit 3c4f636 into main Aug 28, 2024
3 checks passed
@yohamta yohamta deleted the fix-build-issue branch August 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant