Skip to content

Commit

Permalink
Workaround for rust-lang/cargo#10788
Browse files Browse the repository at this point in the history
As described in Cargo Issue 10788, until Rust 1.71 there were
cases where the dependency/feature syntax would not work correctly
when used in combination with the dep:dependency syntax. Workarounds
include adding an explicit feature

dependency = ["dep:dependency"]

but in many (most?) cases it is enough to only enable the dependency feature
if the dependency is already enabled, via the dependency?/feature
syntax.

For context, here are some workarounds employed by others:
- mstange/samply@89456d4
- alexrudy/tonic@f386954
- jwodder/confab@6f0e2fc
  • Loading branch information
dahlbaek committed May 17, 2024
1 parent d1ba3f4 commit 7ccd6f8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion opener/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ maintenance = { status = "passively-maintained" }
[features]
default = ["dbus-vendored"]
reveal = ["dep:url", "dep:dbus", "windows-sys/Win32_System_Com"]
dbus-vendored = ["dbus/vendored"]
dbus-vendored = ["dbus?/vendored"]

[target.'cfg(target_os = "linux")'.dependencies]
bstr = "1"
Expand Down

0 comments on commit 7ccd6f8

Please sign in to comment.