Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export function to manipulate GitPromptSettings #340

Closed
dahlbyk opened this issue Dec 31, 2016 · 3 comments
Closed

Export function to manipulate GitPromptSettings #340

dahlbyk opened this issue Dec 31, 2016 · 3 comments
Milestone

Comments

@dahlbyk
Copy link
Owner

dahlbyk commented Dec 31, 2016

Spawned from #256 (comment), similar to #111.

Pros:

  • Discoverability (module definition, etc)
  • Tab completion
  • Parameter Validation (e.g. BranchBehindAndAheadDisplay "enum")

Cons:

  • More code to maintain
  • Migration path from $GitPromptSettings? Or does function just manipulate the global?
@rkeithhill
Copy link
Collaborator

Pertinent to this discussion (and the discussion on module install script) - PoshCode/PowerShellPracticeAndStyle#79

@rkeithhill
Copy link
Collaborator

You get tab completion/Intellisense with the $GitPromptSettings variable so that really isn't a "pro" for a function.

@rkeithhill
Copy link
Collaborator

For 1.0.0 we're going in the direction of a more structured, strongly typed GitPromptSettings object. If you disagree or think this needs to be reopened, please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants