Merge settings with Posh-Hg because I'm tired of having dueling sets #111
Conversation
|
Could you comment on why you're leaving this just sitting here? |
|
Because I'm not a good maintainer. :( Honestly, I just didn't have time to review when it first came in and forgot to get back to it. I'll try to remedy that soon, sorry. |
|
👍 response, would read again. |
| $Global:VcsPromptStatuses = @() | ||
| } | ||
| function Global:Write-VcsStatus { $Global:VcsPromptStatuses | foreach { & $_ } } | ||
|
|
||
| function global:Write-VcsStatus { $Global:VcsPromptStatuses | Invoke-Command } |
There was a problem hiding this comment.
This addition doesn't actually work as is on PS3. Needs to be foreach { Invoke-Command -ScriptBlock $_ } instead of just Invoke-Command
There was a problem hiding this comment.
Is Invoke-Command -ScriptBlock $_ equivalent to & $_?
There was a problem hiding this comment.
It does appear to behave the same after testing and discussions in #PowerShell. I haven't been able to talk to Joel yet about why he was preferring the Invoke-Command method over &.
There was a problem hiding this comment.
Invoke-Command can't work in the pipeline like that. I wonder if Joel wrote his own version of Invoke-Command that does support pipeline parameters - it actually makes some sense to support.
| $Global:VcsPromptStatuses = @() | ||
| } | ||
|
|
||
| function Global:Write-VcsStatus { $Global:VcsPromptStatuses | foreach { & $_ } } |
There was a problem hiding this comment.
Sorry about that. I can't imagine how I left in my Invoke-Command version.
Submitting a similar set to posh-hg -- could probably go further than this to integrate them, but this is enough for step one