Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redid the Stash-Status from PR #181 from fritzh #215

Merged
merged 2 commits into from
Sep 2, 2015

Conversation

MarkusAmshove
Copy link
Contributor

Hey,

I redid the pullrequest of fritzh for the git stash status in the prompt, as I really like to have it in posh-git.

His PR wasn't requested because he also had changes to the ssh-agent thingy.

stashprompt

@@ -186,6 +188,7 @@ function Get-GitStatus($gitDir = (Get-GitDirectory)) {
HasWorking = [bool]$working
Working = $working
HasUntracked = [bool]$filesAdded
stashCount = $stashCount
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Can you flip the property to PascalCase?

@MarkusAmshove
Copy link
Contributor Author

Stupid mistake, I'm sorry :-)

Should be fixed now.

@dahlbyk
Copy link
Owner

dahlbyk commented Sep 2, 2015

No need to apologize, that's why we have code review. PowerShell is case-insensitive, so it's really just for our benefit.

🎱

dahlbyk added a commit that referenced this pull request Sep 2, 2015
Redid the Stash-Status from PR #181 from fritzh
@dahlbyk dahlbyk merged commit ec7ee5d into dahlbyk:master Sep 2, 2015
@cmarcusreid cmarcusreid mentioned this pull request Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants