-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tab completion for AVH git-flow commands #231
Add tab completion for AVH git-flow commands #231
Conversation
Git for windows (2.x) comes with the AVH edition of git-flow. This active fork contains some commands/sub-commands not present in the original repository. Add these to tab completion. See https://github.com/petervanderdoes/gitflow-avh
release = 'list start finish track publish help delete' | ||
hotfix = 'list start finish track publish help delete' | ||
support = 'list start help' | ||
config = 'list set base' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add version and log? This is what I have on 2.11:
Available subcommands are:
init Initialize a new git repo with support for the branching model.
feature Manage your feature branches.
bugfix Manage your bugfix branches.
release Manage your release branches.
hotfix Manage your hotfix branches.
support Manage your support branches.
version Shows version information.
config Manage your git-flow configuration.
log Show log deviating from base branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.10.1 (AVH Edition)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been this version since v2.10.1 of git-for-windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version
and log
don't have any subcommands, so they don't need to be listed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense. Thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, it didn't click that you meant adding the commands. I guess since those don't make sense there I just assumed you were looking for version and log info for git flow included with git-for-windows. Glad someone else got it. 😊
@@ -14,13 +14,17 @@ $subcommands = @{ | |||
submodule = 'add status init update summary foreach sync' | |||
svn = 'init fetch clone rebase dcommit branch tag log blame find-rev set-tree create-ignore show-ignore mkdirs commit-diff info proplist propget show-externals gc reset' | |||
tfs = 'bootstrap checkin checkintool ct cleanup cleanup-workspaces clone diagnostics fetch help init pull quick-clone rcheckin shelve shelve-list unshelve verify' | |||
flow = 'init feature release hotfix' | |||
flow = 'init feature bugfix release hotfix support help version config finish delete publish rebase' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that help, finish, delete, publish and rebase belong here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I suppose technically 'help' isn't handled here, but even the official completion has it. Makes sense for consistency, if you think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More specifically, this line matches https://github.com/petervanderdoes/git-flow-completion/blob/298a51da9ae39b6cad97b1ad383388fdd9385572/git-flow-completion.bash#L58.
Git for windows (2.x) comes with the AVH edition of git-flow. This active
fork contains some commands/sub-commands not present in the original
repository. Add these to tab completion.
See https://github.com/petervanderdoes/gitflow-avh