Fix that module can be found by not imported?

[dahlbyk]

Fix #350 and #322 (comment), I think?

I can't explain why Get-Module posh-git would find a module but Import-Module posh-git wouldn't find the same. I'm wondering if the Get-Module result should be filtered through Select-Object -First 1 and maybe sorted by version or something?

[rkeithhill]

I'm wondering if the Get-Module result should be filtered through Select-Object -First 1 and maybe sorted by version or something?

But if Get-Module finds anything, it should load the latest version unless one of the Version parameters are specified. In this case, they are not.

Anyway, your fix should eliminate the possibility of error but I would Sort by version -desc and Select the first module.

We should also move the prompt function definition before we import the module so that the import will detect a custom prompt function is in use so it won't set a new prompt that get's clobbered later by the prompt function appearing after the import. It's not that this won't work, it is a slight perf improvement.

[rkeithhill]

See my other comment about using Sort / Select. Also consider moving prompt def before the import statement if we decide to go with PR #349

[dahlbyk]

We should also move the prompt function definition before we import the module so that the import will detect a custom prompt function is in use so it won't set a new prompt that get's clobbered later by the prompt function appearing after the import. It's not that this won't work, it is a slight perf improvement.

I'm inclined to drop the prompt from profile.example.ps1 altogether as part of #349.

I would Sort by version -desc and Select the first module.

Done. Good?

[rkeithhill]

LGTM