Remove Mandatory from Test-PoshGitImportedInScript -Path #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #381
As of #376,
install.ps1
passes$WhatIf
on toAdd-PoshGitToProfile
, which matches a hack added to let tests override$profilePath
. Ultimately this causes$profilePath
to be empty when passed as aMandatory
parameter toTest-PoshGitImportedInScript
. Two-part fix:Test-PoshGitImportedInScript
can correctly handle a$null
/empty$Path
, so it's safer to removeMandatory
.