-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tab expansion for non-ASCII file paths #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add this to the CHANGELOG.md. :-)
@rkeithhill do you think we would be able to reasonably test this particularly quote/encoding round-trip? |
I suspect not. ;-) I added stuff I found but no guarantees that I found everything.
Not sure. Would have to experiment with it. |
Figured out a failing test that is made to pass:
Oddly, VS Code is showing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! LGTM.
Fix #64 now that #359 and #397 have fixed the encoding issue I encountered at the time.
cc @haacked