-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PowerShell v2 support. #427
Changes from 1 commit
cf148fd
b4165df
4026378
28c3bba
d4b1669
1241644
6b2d854
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ os: | |
|
||
branches: | ||
only: | ||
- master | ||
- develop | ||
|
||
init: | ||
- git config --global core.autocrlf true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
<metadata> | ||
<id>poshgit</id> | ||
<title>posh-git</title> | ||
<version>0.7.0</version> | ||
<version>1.0.0-pre00</version> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
<authors>Keith Dahlby, Mark Embling, Jeremy Skinner, Keith Hill</authors> | ||
<owners>Keith Dahlby</owners> | ||
<description>### posh-git | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
@{ | ||
|
||
# Script module or binary module file associated with this manifest. | ||
ModuleToProcess = 'posh-git.psm1' | ||
RootModule = 'posh-git.psm1' | ||
|
||
# Version number of this module. | ||
ModuleVersion = '0.7.0' | ||
ModuleVersion = '1.0.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Really wish this supported a prerelease suffix. I'd like to be able to differentiate between folks using a PowerShell Gallery version and this branch. Maybe use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. '1.0.0' comes out as version 1.0.0.-1 so the order between release and pre is wrong. :-( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am mostly concerned with the issue template version script showing a difference between loading from An alternative would be to include the posh-git module's path, perhaps with a replacement of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It may actually be desirable for a local version (think fork with personalized features) to win out over an official version (e.g. inherited from GitHub Desktop). Maybe? Of course the personalized fork could just bump the version... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The way I handle that scenario is to import by path e.g: Import-Module $Home\GitHub\dahlbyk\posh-git\src\posh-git.psd1 Development is in the works for PowerShellGet/PSGallery to support prereleases. I'm hoping this problem will get solved in the coming months. PowerShell/PowerShell-RFC#42 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but doing that if posh-git has already been loaded, e.g. in the GitHub Desktop shell, leaves you with two posh-git modules loaded. If one of those is 0.7.0 and the other is a personal fork that also reports 0.7.0, I have to check path to differentiate. Thus my suggestion of the extra That said, also including There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK. But I'll update the issue template file on master in a separate PR. Also, regarding those extra commands to not export. I'll remove those. I'm guilty of adding Get-GitBranch for testing purposes but I think Pesters's InModuleScope will get me access to this function. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if we leave in |
||
|
||
# ID used to uniquely identify this module | ||
GUID = '74c9fd30-734b-4c89-a8ae-7727ad21d1d5' | ||
|
@@ -19,27 +19,26 @@ Copyright = '(c) 2010-2017 Keith Dahlby and contributors' | |
Description = 'Provides prompt with Git status summary information and tab completion for Git commands, parameters, remotes and branch names.' | ||
|
||
# Minimum version of the Windows PowerShell engine required by this module | ||
PowerShellVersion = '2.0' | ||
PowerShellVersion = '3.0' | ||
|
||
# Functions to export from this module | ||
FunctionsToExport = @( | ||
'Invoke-NullCoalescing', | ||
'Add-PoshGitToProfile', | ||
'Write-GitStatus', | ||
'Write-Prompt', | ||
'Write-VcsStatus', | ||
'Enable-GitColors', | ||
'Get-AliasPattern', | ||
'Get-GitBranch', | ||
'Get-GitStatus', | ||
'Enable-GitColors', | ||
'Get-GitDirectory', | ||
'TabExpansion', | ||
'Get-AliasPattern', | ||
'Update-AllBranches', | ||
'Write-GitStatus', | ||
'Write-Prompt', | ||
'Write-VcsStatus', | ||
'Get-SshAgent', | ||
'Start-SshAgent', | ||
'Stop-SshAgent', | ||
'Add-SshKey', | ||
'Get-SshPath', | ||
'Update-AllBranches', | ||
'TabExpansion', | ||
'tgit' | ||
) | ||
|
||
|
@@ -50,7 +49,7 @@ CmdletsToExport = @() | |
VariablesToExport = @() | ||
|
||
# Aliases to export from this module | ||
AliasesToExport = @('??') | ||
AliasesToExport = @() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove until we stumble on an alias we want to export (unlikely)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. An empty array helps with overall system performance. If you omit the entry, PowerShell does more expensive work to see if you meant to export any aliases. |
||
|
||
# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell. | ||
PrivateData = @{ | ||
|
@@ -61,13 +60,13 @@ PrivateData = @{ | |
Tags = @('git', 'prompt', 'tab', 'tab-completion', 'tab-expansion', 'tabexpansion') | ||
|
||
# A URL to the license for this module. | ||
LicenseUri = 'https://github.com/dahlbyk/posh-git/blob/v0.7.0/LICENSE.txt' | ||
LicenseUri = 'https://github.com/dahlbyk/posh-git/blob/develop/LICENSE.txt' | ||
|
||
# A URL to the main website for this project. | ||
ProjectUri = 'https://github.com/dahlbyk/posh-git' | ||
|
||
# ReleaseNotes of this module | ||
ReleaseNotes = 'https://github.com/dahlbyk/posh-git/blob/v0.7.0/CHANGELOG.md' | ||
ReleaseNotes = 'https://github.com/dahlbyk/posh-git/blob/develop/CHANGELOG.md' | ||
|
||
} # End of PSData hashtable | ||
|
||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to keep both
master
anddevelop
. That change may also need to find its way intomaster
(the default branch) for it to take effect (not certain about that).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally there would be a way in appveyor.yml to specify the "current target branch". So if we put in both
master
anddevelop
will that attempt to build a PR meant for develop on master also? If so, that would likely fail. Then again, I'm a total AppVeyor n00b.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just means any change in
master
ordevelop
will be built. We will probably want to add a badge fordevelop
, too.PRs are built regardless of target; this setting is (ideally) only for merged PRs.