Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide profile.example.ps1 warning for Chocolatey #444

Merged
merged 4 commits into from
Feb 27, 2017
Merged

Hide profile.example.ps1 warning for Chocolatey #444

merged 4 commits into from
Feb 27, 2017

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented Feb 25, 2017

Fixes #442 with two changes:

  1. Hides the warning if posh-git is managed by Chocolatey, since we can largely control use of profile.example.ps1 with the installer
  2. Replaces the "copy its contents into your $PROFILE" suggestion with a better recommendation

#338 notwithstanding, one useful thing profile.example.ps1 does is call Start-SshAgent, so I've also added Add-PoshGitToProfile -StartSshAgent to add the same.

@dahlbyk
Hide profile.example.ps1 warning if installed w/ choco
6efec4f 
Either we'll keep Chocolatey support for 1.0 and handle
profile.example.ps1 gracefully, or we'll never release a version that
doesn't include the file (so the warning is meaningless).
@dahlbyk
Add StartSshAgent parameter to Add-PoshGitToProfile
b4ba48e
@dahlbyk
choco uninstall: remove Start-SshAgent from $PROFILE
57848d3
@dahlbyk dahlbyk added this to the v0.7.1 milestone Feb 25, 2017
@dahlbyk dahlbyk mentioned this pull request Feb 25, 2017
Closed
rkeithhill
rkeithhill approved these changes Feb 25, 2017
View reviewed changes
Copy link
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think it is worth adding a pester test for the new parameter to Utils.Tests.ps1?

@dahlbyk
Copy link
Owner Author

dahlbyk commented Feb 26, 2017

Do you think it is worth adding a pester test for the new parameter to Utils.Tests.ps1?

I do, and have.

@dahlbyk dahlbyk merged commit 7d292db into master Feb 27, 2017
@dahlbyk dahlbyk deleted the profile-example-warning branch February 27, 2017 14:53
@dahlbyk dahlbyk mentioned this pull request Feb 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeithhill rkeithhill rkeithhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dahlbyk @rkeithhill