Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Write-Prompt' to be able use Black as foreground color. #468

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Fix 'Write-Prompt' to be able use Black as foreground color. #468

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e9b90d
Fix 'Write-Prompt' to be able use Black as foreground color.
vladimir-poleh Apr 17, 2017
d2c2a43
Fix for PSScriptAnalyzer warning in VS Code.
vladimir-poleh Apr 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitPrompt.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ if (Get-Module NuGet) {

function Write-Prompt($Object, $ForegroundColor = $null, $BackgroundColor = $null) {
$s = $global:GitPromptSettings
if ($s -and !$ForegroundColor) {
if ($s -and $ForegroundColor -eq $null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! To eliminate a PSScriptAnalyzer warning in VSCode, would you mind changing that ever so slightly to:

if ($s -and ($null -eq $ForegroundColor)) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info about PSScriptAnalyzer.

$ForegroundColor = $s.DefaultForegroundColor
}

Expand Down