-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.7.2 #522
Release v0.7.2 #522
Conversation
Related #478. This is a better fix. By specifying the CommandType as Application we can continue looking for `git` (exe or cmd) but avoiding any potential aliases the user may have created for "git".
Allow advanced users to invoke the $scriptblock from their own prompt functions.
And export Get-PromptPath to expose our default path logic
https://chocolatey.org/packages/poshgit/0.7.2-pre1 is pushed, pending approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I can't think of anything else blocking finalizing this release. Am I missing anything? |
src/posh-git.psd1
Outdated
|
||
# TODO: REMOVE BEFOE RELEASE | ||
PreReleaseVersion = 'pre0' | ||
Prerelease = 'pre1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to update this or do you do that manually before you publish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll drop this and fix all the other -pre1
references before I commit and tag v0.7.2
.
Nothing that I'm aware of. Although the README needs an update to at least mention that another version exists to support ANSI and PS Core 6. |
README.md
Outdated
- `develop` includes breaking changes, toward [v1.0](https://github.com/dahlbyk/posh-git/issues/328). | ||
( [README](https://github.com/dahlbyk/posh-git/blob/develop/README.md) | ||
• [CHANGELOG](https://github.com/dahlbyk/posh-git/blob/develop/CHANGELOG.md) ) | ||
- Supports PowerShell 5 and PowerShell Core 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the first one to Windows PowerShell 5.x
- includes 5.0 and 5.1.
README.md
Outdated
@@ -22,9 +22,12 @@ You can also tab complete remote names and branch names e.g.: `git pull or<tab> | |||
- `master` avoids breaking changes, maintaining v0.x. | |||
( [README](https://github.com/dahlbyk/posh-git/blob/master/README.md) | |||
• [CHANGELOG](https://github.com/dahlbyk/posh-git/blob/master/CHANGELOG.md) ) | |||
- Supports PowerShell 3+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be Windows PowerShell 3+
to help make distinction between Windows PowerShell and PowerShell Core.
I'm updating this changelog for an official v0.7.2 release before I shift focus to finalizing v1.
As perhaps the final v0.x release, I have updated the readme to refer to |
Personally, I'd prefer that we just rename |
@rkeithhill (or anyone!) can I get a final sanity check here before I tag |
Sure. I have to drive home from my son's swim practice. I'll test it in about 30 minutes. |
I had forgotten about this change, which I had started on an old computer (9c37c76#r161387410). Anyway, it seems like an improvement for this branch, even if it will change substantially in v1. |
LGTM. I've been testing the various new features / fixes in the release. So far, it all looks goodl |
Apparently I accidentally published v0.7.2 back in January
Sigh. v0.7.3 has been published to Chocolatey and PowerShell Gallery. |
I've pulled a few backward-compatible changes down from
develop
. In particular:$GitPromptScriptBlock
from Refactor Settings & Write-GitStatus function #513 for Usage of default prompt but with custom side effects in prompt function #501$GitPromptSettings.DefaultPromptPath
from Default Prompt Colors #520 for Add custom path rendering in prompt #469I also split off the changelog entries from #521 that apply to this release.