Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten window title text #567

Merged
merged 2 commits into from
Apr 20, 2018
Merged

Shorten window title text #567

merged 2 commits into from
Apr 20, 2018

Conversation

rkeithhill
Copy link
Collaborator

@rkeithhill rkeithhill commented Apr 20, 2018

Modify Get-PromptPath to return full dir when path is equal to $Home.
It will use ~ when path is a subdir under $HOME.

This does not address other path shortening techniques.
We could do those in this PR or another one.

Fixes #565

Also I think this supersedes PR #538 for the 1.x branch.

@rkeithhill rkeithhill requested a review from dahlbyk April 20, 2018 01:14
@rkeithhill
Copy link
Collaborator Author

Working on the test failures.

@dahlbyk
Copy link
Owner

dahlbyk commented Apr 20, 2018

Please rebase on latest and squash your test fixes.

@dahlbyk dahlbyk added this to the v1.0 milestone Apr 20, 2018
@rkeithhill rkeithhill force-pushed the rkeithhill/window-title-mods branch from 84a2063 to ab1d92b Compare April 20, 2018 02:53
@rkeithhill
Copy link
Collaborator Author

Hopefully this will merge with the branch name change. :-0

@dahlbyk
Copy link
Owner

dahlbyk commented Apr 20, 2018

Hopefully this will merge with the branch name change. :-0

GitHub will block deleting develop until all PRs targeting the branch have been merged/closed.

@dahlbyk dahlbyk changed the base branch from develop to master April 20, 2018 05:24
rkeithhill and others added 2 commits April 20, 2018 00:36
Modify Get-PromptPath to return full dir when path is equal to $Home.
It will use ~ when path is in a subdir *under* $HOME.

This does not address other path shortening techniques.
We could do those in this PR or another one.

Fixes #565
@dahlbyk dahlbyk force-pushed the rkeithhill/window-title-mods branch from ab1d92b to aec5c95 Compare April 20, 2018 05:37
Copy link
Owner

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm partial to tildes, so I put that back between the status/path and PowerShell session information.

@rkeithhill
Copy link
Collaborator Author

Oh yeah, was that because of some conemu issue?

@rkeithhill
Copy link
Collaborator Author

Also, can we merge this then? :-)

@dahlbyk dahlbyk merged commit dcb96a4 into master Apr 20, 2018
@dahlbyk
Copy link
Owner

dahlbyk commented Apr 20, 2018

Oh yeah, was that because of some conemu issue?

Started that way, yeah: 1ed6d4d

@dahlbyk dahlbyk deleted the rkeithhill/window-title-mods branch April 20, 2018 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants