Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitPromptValues global to allow error status display in prompt #684

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

rkeithhill
Copy link
Collaborator

@rkeithhill rkeithhill commented Jul 2, 2019

It is useful to display the error status of the last command. But in
order to do that we must preserve the value of $? and make the
original $LASTEXITCODE available to string expansion in the prompt.

cc #681

@rkeithhill rkeithhill force-pushed the rkeithhill/add-poshgitvalues branch from f927f6d to 2c76416 Compare July 2, 2019 04:56
@rkeithhill rkeithhill requested a review from dahlbyk July 2, 2019 04:56
@rkeithhill rkeithhill force-pushed the rkeithhill/add-poshgitvalues branch 3 times, most recently from a8d3b47 to 6643d04 Compare July 4, 2019 15:12
…is useful to display the error status of the last command. But inorder to do that we must preserve the value of $? and make theoriginal $LASTEXITCODE available to string expansion in the prompt.
@rkeithhill rkeithhill force-pushed the rkeithhill/add-poshgitvalues branch from 6643d04 to 1d40ee0 Compare July 4, 2019 15:16
@rkeithhill rkeithhill merged commit a64e5e0 into master Jul 4, 2019
@rkeithhill rkeithhill deleted the rkeithhill/add-poshgitvalues branch July 4, 2019 15:20
@dahlbyk
Copy link
Owner

dahlbyk commented Sep 11, 2019

Belated 👍

This is great!

@rkeithhill
Copy link
Collaborator Author

Thanks!

@dahlbyk dahlbyk added this to the v1.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants