fix: reduce deprecated api and node warnings

[himself65]

Fix the warning on node.js 20

You did not run Node.js with the `--conditions react-server` flag. Any "react-server" override will only work with ESM imports.

Upstream: nodejs/node#50885

And deprecated API on node.js 18

(node:14372) DeprecationWarning: Obsolete loader hook(s) supplied and will be ignored: getSource, transformSource

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
waku	✅ Ready (Inspect)	Visit Preview	Nov 30, 2023 6:41am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 955202f:

Sandbox	Source
Vanilla Typescript	Configuration
React	Configuration
React TypeScript	Configuration

[dai-shi]

I understand the Node 18 warning, but how the Node 20 warning happens? Are we not use ESM imports?

[himself65]

I understand the Node 18 warning, but how the Node 20 warning happens? Are we not use ESM imports?

This is complex. i read the nodejs source code. Reason is conditions will not pass to the esm module in worker thread. BUT, cjs will. So in the first time, require(react) is in correct condition(used in webpack source code). Second time when you import react-server-webpack, it’s not react-server condition actually

[dai-shi]

The change looks good to me. My hesitation is that I will not be able to remember that this change is just about reducing warnings.
Can you add source code comments which include the link to this PR?

[dai-shi]

https://github.com/dai-shi/waku/actions/runs/7012521326/job/19077187950?pr=183
Do you know why CI timeouts sometimes?

[himself65]

dai-shi/waku/actions/runs/7012521326/job/19077187950?pr=183 Do you know why CI timeouts sometimes?

There might be some flaky. or in some cases, CI is slower than usual cause the build is overdue. Let me debug it

[himself65]

could you run that again with debug log?

I will go to dinner now. do this later

[himself65]

Will rebase this later

[dai-shi]

LGTM