Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support omitting file extensions in import statements #629

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

himself65
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 2:16am

Copy link

codesandbox-ci bot commented Mar 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It works.

@dai-shi dai-shi merged commit 5fa2c16 into dai-shi:main Mar 28, 2024
28 checks passed
@dai-shi dai-shi mentioned this pull request Mar 28, 2024
import { container } from './styles.css.js';
import { Counter } from './Counter.js';
import { Banner } from './Banner.js';
import { container } from './styles.css';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a temporary error like this in DEV, when you reload the browser.

Untitled

Adding back .js fixes it.

Do you have a better solution? @himself65

dai-shi added a commit that referenced this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants