fix: build target for vercel will throw error #699
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
PerfectPan
force-pushed
the
fix/build-error
branch
from
975539e to
655893e
Compare
PerfectPan
force-pushed
the
fix/build-error
branch
from
655893e to
84f2c87
Compare
PerfectPan
force-pushed
the
fix/build-error
branch
from
84f2c87 to
8f37db7
Compare
| @@ -38,7 +38,7 @@ export function rscServePlugin(opts: { | |||
| config(viteConfig) { | |||
| // FIXME This seems too hacky (The use of viteConfig.root, '.', path.resolve and resolveFileName) | |||
| const entriesFile = resolveFileName( | |||
| path.resolve(viteConfig.root || '.', opts.srcDir, SRC_ENTRIES + '.js'), | |||
| path.resolve(viteConfig.root || '.', opts.srcDir, SRC_ENTRIES), | |||
There was a problem hiding this comment.
Can you try this?
| path.resolve(viteConfig.root || '.', opts.srcDir, SRC_ENTRIES), | |
| path.resolve(viteConfig.root || '.', opts.srcDir, SRC_ENTRIES + '.jsx'), |
There was a problem hiding this comment.
I tried, it seems ok as well.
PerfectPan
force-pushed
the
fix/build-error
branch
2 times, most recently
from
421a9a2 to
07bc408
Compare
PerfectPan
force-pushed
the
fix/build-error
branch
from
07bc408 to
5c78210
Compare
|
All the windows tests are failed. Maybe there are another issues? |
|
probably, wrap with |
PerfectPan
force-pushed
the
fix/build-error
branch
from
0bff899 to
f41d004
Compare
Ha, you are right |
|
I see the failed test stuck on |
| const entriesFile = resolveFileName( | ||
| path.resolve(viteConfig.root || '.', opts.srcDir, SRC_ENTRIES + '.js'), | ||
| normalizePath( |
There was a problem hiding this comment.
Wait, on second look, I think normalizePath should be outside of resolveFileName.
There was a problem hiding this comment.
oh, I think you are right. resolveFileName will use node:fs to check file exists.
e2e/multi-platform.spec.ts
Outdated
| import { rm } from 'node:fs/promises'; | ||
| import { expect } from '@playwright/test'; | ||
|
|
||
| const cwd = fileURLToPath(new URL('../examples/01_template', import.meta.url)); |
There was a problem hiding this comment.
Can you add test with 20_minimal too?
Solve #700
The bug was introduced in #682, the reason is that the logic of https://github.com/dai-shi/waku/pull/682/files#diff-6de2cc9d9f6423e3f4faa0cb1a6200112f1bc057af0db1a9362fe6117c51d18aR79-R82 was adjusted.
I think the logic now assmues the entry file is endsWith .jsx while while the dynamic import in serve-vercel.js is endsWith .js
I am not so sure it is a correct way to remove .js extension, but I added the dry run testing, maybe it can help.