Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling effect #8

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Scrolling effect #8

merged 4 commits into from
Feb 12, 2025

Conversation

kcabalonga
Copy link

Description

Please provide a summary of the changes made in this pull request:

  • Filled sidebar circle depending on the index, removed the sidebar completely on mobile
  • commented out scroll-snap-align property as it was hindering scrolling back up
  • replaced stacks in ScrolingEffect + Mobile with the PhotoStack components

Checklist

  • I have performed a self-review of my own code
  • I have tested changes for mobile, if applicable

Screenshots

Please Include screenshots or links to visual changes for any new component (if applicable).

@tsakshi011 tsakshi011 merged commit e7074ac into main Feb 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnyr5 donnyr5 Awaiting requested review from donnyr5 donnyr5 is a code owner

@tsakshi011 tsakshi011 Awaiting requested review from tsakshi011 tsakshi011 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcabalonga @tsakshi011