Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing date range on extension and mobile #3611

Merged
merged 7 commits into from
Oct 2, 2024
Merged

fix: missing date range on extension and mobile #3611

merged 7 commits into from
Oct 2, 2024
+52 −6

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Oct 2, 2024 •
edited by github-actions bot
Loading

Changes

  • Fix missing date range on mobile and extension.
  • Removed unnecessary dropdown about algo (since explore tabs, we don't need that anymore).

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

MI-508 #done

Preview domain

https://mi-508.preview.app.daily.dev

@sshanzel sshanzel requested a review from a team as a code owner October 2, 2024 07:49
@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 10:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Oct 2, 2024 10:19am

@sshanzel
Copy link
Member Author

sshanzel commented Oct 2, 2024 •
edited
Loading

Previews:
Screenshot 2024-10-02 at 3 44 20 PM
Screenshot 2024-10-02 at 4 03 41 PM
Screenshot 2024-10-02 at 3 48 21 PM
Screenshot 2024-10-02 at 3 48 17 PM
Screenshot 2024-10-02 at 3 48 15 PM

@sshanzel sshanzel merged commit 49e3a94 into main Oct 2, 2024
10 checks passed
@sshanzel sshanzel deleted the MI-508 branch October 2, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nensidosari nensidosari nensidosari approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@AmarTrebinjac AmarTrebinjac Awaiting requested review from AmarTrebinjac AmarTrebinjac is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshanzel @nensidosari