Skip to content

Commit

Permalink
Dailymotion Bid Adapter: no fallback for startdelay and plcmt
Browse files Browse the repository at this point in the history
  • Loading branch information
Kevin Siow committed Jul 10, 2024
1 parent 672f3eb commit 611b0b3
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion libraries/creative-renderer-display/renderer.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion libraries/creative-renderer-native/renderer.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/dailymotionBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ export const spec = {
minduration: bid.mediaTypes?.[VIDEO]?.minduration || 0,
maxduration: bid.mediaTypes?.[VIDEO]?.maxduration || 0,
playbackmethod: bid.mediaTypes?.[VIDEO]?.playbackmethod || [],
plcmt: bid.mediaTypes?.[VIDEO]?.plcmt || 1, // Fallback to instream considering logic of `isBidRequestValid`
plcmt: bid.mediaTypes?.[VIDEO]?.plcmt,
protocols: bid.mediaTypes?.[VIDEO]?.protocols || [],
skip: bid.mediaTypes?.[VIDEO]?.skip || 0,
skipafter: bid.mediaTypes?.[VIDEO]?.skipafter || 0,
skipmin: bid.mediaTypes?.[VIDEO]?.skipmin || 0,
startdelay: bid.mediaTypes?.[VIDEO]?.startdelay || 0,
startdelay: bid.mediaTypes?.[VIDEO]?.startdelay,
w: bid.mediaTypes?.[VIDEO]?.w || 0,
h: bid.mediaTypes?.[VIDEO]?.h || 0,
},
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/dailymotionBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,7 @@ describe('dailymotionBidAdapterTests', () => {
minduration: 0,
maxduration: 0,
playbackmethod: [],
plcmt: 1,
plcmt: undefined,
protocols: [],
skip: 0,
skipafter: 0,
Expand Down Expand Up @@ -1052,12 +1052,12 @@ describe('dailymotionBidAdapterTests', () => {
minduration: 0,
maxduration: 0,
playbackmethod: [],
plcmt: 1,
plcmt: undefined,
protocols: [],
skip: 0,
skipafter: 0,
skipmin: 0,
startdelay: 0,
startdelay: undefined,
w: 0,
h: 0,
},
Expand Down

0 comments on commit 611b0b3

Please sign in to comment.