Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: es (spanish) localization #64

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Conversation

danielweck
Copy link
Member

Follow-up to PR: #61

Changes: sorted JSON keys, checked for invalid keys (missing, unused)

Many thanks to @nvdaes !

@danielweck danielweck merged commit 7c015fa into master Jul 30, 2019
@danielweck danielweck deleted the pr/nvdaes/esLocalization branch July 30, 2019 20:44
@danielweck
Copy link
Member Author

Dear @nvdaes would you be so kind as to consider translating the Ace (core) strings as well?

As mentioned in this wiki page:
https://github.com/daisy/ace-gui/wiki/Localization

...here is a link to the Ace (core) localization primer:
https://github.com/daisy/ace/wiki/Localization

@nvdaes
Copy link
Contributor

nvdaes commented Jul 31, 2019

Replying to @danielweck

Dear @nvdaes would you be so kind as to consider translating the Ace (core) strings as well?

Yes, I started doing this as well. I will open a pull request when the three mentioned files are ready.
I will share this in spanish community so people have a chance for comments.
Thank you.

@danielweck
Copy link
Member Author

Thank you @nvdaes it is a lot of work. Much appreciated. Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants