[WIP] [DO NOT MERGE] v4.7.2 diff #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xe-patch-listitem scripts/axe-patch-only-list-items)
…M run test-fast command
…xtension (e.g. 4.1.3-daisy.0)
…-has-main (DAISY Ace)
… page-has-main (DAISY Ace)
…py ... so I need to test a full commit)
…o main landmark at all
…. if it has one (optional)"
…ils in both Firefox and Chrome)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS FOR TRACKING / CODE DIFF PURPOSES ONLY, DO NOT MERGE.
This PR supersedes #10
NPM package publish:
https://www.npmjs.com/package/@daisy/axe-core-for-ace
https://www.npmjs.com/package/@daisy/axe-core-for-ace/v/4.7.2-canary.1
Tracking of code changes since
4.7.2:dequelabs/axe-core@v4.7.2...master
dequelabs/axe-core@v4.7.2...develop
Axe
4.7.2official release: https://github.com/dequelabs/axe-core/tree/v4.7.2...and changelog: https://github.com/dequelabs/axe-core/blob/v4.7.2/CHANGELOG.md
Ace "legacy" patches:
https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-aria-roles.js#L3-L15
https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-is-aria-role-allowed.js#L74-L103
https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-listitem.js#L97-L134
https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-only-list-items.js#L215-L272
https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L220-L229
https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L93-L176
https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L179-L194
https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L195-L208
https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L209-L215
Useful references:
Ace:
https://github.com/daisy/ace/blob/ace-next/packages/ace-core/src/scripts/ace-axe.js#L94
https://github.com/daisy/ace/blob/ace-next/tests/data/axerule-dpubroles/EPUB/content_001.xhtml#L13-L17
daisy/ace#274 (comment)
daisy/ace#239
daisy/ace#274
W3C:
https://lists.w3.org/Archives/Public/public-publ-wg/2020Sep/0023.html
https://lists.w3.org/Archives/Public/public-epub-wg/2020Sep/0007.html
w3c/dpub-aria#22
w3c/dpub-aria#15
w3c/epub-specs#1316
w3c/html-aria#99
w3c/aria#748
w3c/epubcheck#1018
https://www.w3.org/TR/dpub-aria-1.0/
https://w3c.github.io/dpub-aria/
https://www.w3.org/TR/html-aria/
https://idpf.github.io/epub-guides/epub-aria-authoring/
Axe:
dequelabs#2759
dequelabs#1677 (comment)
Daisy-Axe:
https://github.com/daisy/axe-core/blob/v4.7.2_DAISY/test/integration/rules/aria-allowed-role/aria-allowed-role.html#L7-L10
https://github.com/daisy/axe-core/blob/v4.7.2_DAISY/lib/commons/aria/lookup-table.js#L592-L608
https://github.com/daisy/axe-core/blob/v4.7.2_DAISY/lib/checks/aria/aria-required-children-evaluate.js#L12