Fix crashes due to illegal memory access on windows #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align JNA version with current version distributed in DAISY Pipeline 2.
Crashes were detected in production tests when Hyphenator is used with the version 5.14 of JNA. See daisy/pipeline-modules#102.
The crashes were encountered when a garbage collection thread cleaned pointers declared in the hyphenation function. Those pointers were possibly still reserved by the JNA running thread while being cleaned up. The pointers lifetime has been moved to the object level with a ThreadLocal wrapper for thread safety.
|
@NPavie Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashes and "Illegal memory access" error reported in the pipeline app when using JNA 5.14 on windows 10+.
Crashes were caused by a GC thread, that seemed to clean PointersByReference declared in the hyphenate function while still being reserved in the JNA runner.
This PR adds
ThreadLocalfor thread safety (in case of multithreaded calls to the native function)