Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify configuration #141

Closed
4 tasks done
bertfrees opened this issue Oct 2, 2017 · 3 comments
Closed
4 tasks done

Simplify configuration #141

bertfrees opened this issue Oct 2, 2017 · 3 comments
Assignees
@bertfrees
Labels
4 - Done documentation usability
Milestone
v1.11.0

Comments

@bertfrees
Copy link
Member

bertfrees commented Oct 2, 2017 •
edited
Loading

See #140 (comment), (comment 2)

  • Convert environment variables to Java system properties at run time
  • Rename all Pipeline properties to org.daisy.pipeline.foo
  • Document undocumented properties (http://daisy.github.io/pipeline/wiki/Configuration-Files). All the TTS related properties should be documented on the TTS page and should be linked from the general configuration page.
  • Make "job-local/dynamic" TTS config properties fall back to system properties instead of the "static" TTS config properties specified via tts.config system property. The static TTS config can still be used for other configuration like voices, CSS, etc. (handled by the so-called extensions).

Other todos moved to new issue: #152
@egli
Copy link
Member

egli commented Oct 2, 2017

See also this so question and Spring Evironment (don't know if this is usable without using Spring though)

@bertfrees
Copy link
Member Author

bertfrees commented Oct 4, 2017 •
edited
Loading

In addition to mapping environment variables to Java system properties (at run time), map Maven properties to the default values in system.properties (at build time).

Environment variables should overwrite the default values in system.properties, unlike how it works now.

@bertfrees bertfrees self-assigned this Oct 19, 2017
@bertfrees bertfrees mentioned this issue Oct 19, 2017
Closed
@bertfrees bertfrees mentioned this issue Nov 2, 2017
Closed
@bertfrees bertfrees added this to the v1.11.0 milestone Jan 4, 2018
bertfrees added a commit to daisy/pipeline-mod-braille that referenced this issue Jan 25, 2018
@bertfrees
Make all Pipeline properties uniform
7c7b583 
i.e. make them all start with "org.daisy.pipeline"

see daisy/pipeline-assembly#141
@bertfrees bertfrees mentioned this issue Mar 8, 2018
Open
bertfrees added a commit to daisy/pipeline-framework that referenced this issue Mar 13, 2018
@bertfrees
Make all Pipeline properties uniform
5a68dee 
i.e. make them all start with "org.daisy.pipeline"

see daisy/pipeline-assembly#141
bertfrees added a commit to daisy/pipeline-mod-audio that referenced this issue Mar 13, 2018
@bertfrees
Make all Pipeline properties uniform
1028ef0 
i.e. make them all start with "org.daisy.pipeline". This includes the
TTS properties, which now start with "org.daisy.pipeline.tts".

see daisy/pipeline-assembly#141
bertfrees added a commit that referenced this issue Mar 28, 2018
@bertfrees
Some configuration clean up
004003b 
see #141
@bertfrees
Copy link
Member Author

First phase done in daisy/pipeline-framework@6b02d70, daisy/pipeline-framework@5a68dee, 004003b, daisy/pipeline-mod-tts@c08c56a, daisy/pipeline@1afe2c8

@bertfrees bertfrees mentioned this issue Apr 3, 2018
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertfrees bertfrees

Labels
4 - Done documentation usability
Projects
None yet
Milestone
v1.11.0
Development

No branches or pull requests
2 participants
@egli @bertfrees