-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Stats): removed incorrect import on examples #339
Conversation
👷 Deploy Preview for react-daisyui processing.
|
1 similar comment
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this. The subcomponents look a little cumbersome (and ugly) in this case so maybe worth revisiting how we handle the <Stats>
component in the future.
We could probably combine Stat
and Item
into one component. Can't remember why they were ever separate components to begin with.
I will take a look into that today and see what I can do! |
After giving it a further look, I don't think combining I'd suggest merging this to correct the docs usage for now and after deciding the new component structure change it for a new version since it will also be a breaking change. What do you think @benjitrosch? Edit: I created a PR so you can take a look! #341 |
Thanks for looking into that. We can't update the docs at the moment since they're broken and are reverted to a previous release. So if it's just for the sake of updating the docs, we're unfortunately out of luck. On the bright side, that gives us time to come up with a better solution @dev0T 😅 |
I forgot about that issue! haha I did create a new PR with my suggested approach, take a look whenever you have the time and let me know if you have any questions! #341 |
Hey @benjitrosch! Since the docs aren't broken anymore, can this be merged? Thanks! |
Adresses #338.
The examples were not using the library correctly, making use of internal imports.