-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: local module path matching #202
Conversation
@ldez thanks for your contribution! Could you sign your commit then we can make it land? |
the commits are already signed |
Please sign commits refer to this Github Doc. After signed, we can see "verified" in the commits page. |
Signed-off-by: Fernandez Ludovic <ldez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You were talking about this right? So you were asking ldez to use --signoff in addition of signing commit. Right. |
Check To sign the commits, please refer to https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. You can use |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/daixiang0/gci](https://github.com/daixiang0/gci) | `v0.13.3` -> `v0.13.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fdaixiang0%2fgci/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fdaixiang0%2fgci/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fdaixiang0%2fgci/v0.13.3/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fdaixiang0%2fgci/v0.13.3/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>daixiang0/gci (github.com/daixiang0/gci)</summary> ### [`v0.13.4`](https://github.com/daixiang0/gci/releases/tag/v0.13.4) [Compare Source](https://github.com/daixiang0/gci/compare/v0.13.3...v0.13.4) #### What's Changed - fix some typos and style in code and documentation by [@​ccoVeille](https://github.com/ccoVeille) in [daixiang0/gci#201 - Add boringcrypto experiment pkg by [@​phamvinhdat](https://github.com/phamvinhdat) in [daixiang0/gci#194 - fix: local module path matching by [@​ldez](https://github.com/ldez) in [daixiang0/gci#202 - bump up to v0.13.4 by [@​daixiang0](https://github.com/daixiang0) in [daixiang0/gci#204 #### New Contributors - [@​phamvinhdat](https://github.com/phamvinhdat) made their first contribution in [daixiang0/gci#194 **Full Changelog**: daixiang0/gci@v0.13.3...v0.13.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/daixiang0/gci](https://github.com/daixiang0/gci) | `v0.13.3` -> `v0.13.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fdaixiang0%2fgci/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fdaixiang0%2fgci/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fdaixiang0%2fgci/v0.13.3/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fdaixiang0%2fgci/v0.13.3/v0.13.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>daixiang0/gci (github.com/daixiang0/gci)</summary> ### [`v0.13.4`](https://github.com/daixiang0/gci/releases/tag/v0.13.4) [Compare Source](https://github.com/daixiang0/gci/compare/v0.13.3...v0.13.4) #### What's Changed - fix some typos and style in code and documentation by [@&open-telemetry#8203;ccoVeille](https://github.com/ccoVeille) in [daixiang0/gci#201 - Add boringcrypto experiment pkg by [@&open-telemetry#8203;phamvinhdat](https://github.com/phamvinhdat) in [daixiang0/gci#194 - fix: local module path matching by [@&open-telemetry#8203;ldez](https://github.com/ldez) in [daixiang0/gci#202 - bump up to v0.13.4 by [@&open-telemetry#8203;daixiang0](https://github.com/daixiang0) in [daixiang0/gci#204 #### New Contributors - [@&open-telemetry#8203;phamvinhdat](https://github.com/phamvinhdat) made their first contribution in [daixiang0/gci#194 **Full Changelog**: daixiang0/gci@v0.13.3...v0.13.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
golangci/golangci-lint#4608
The value
path
can't end with/
because a module name can't end with/
, so the append of/
doesn't need to be checked.This PR has no problem with modules without packages (
spec.Path == m.Path
).Closes #203