Add missing sync on indicesThatCannotBeCreated (elastic#97869)

If auto-creating multiple indices then the responses may arrive concurrently so we must properly synchronize modifications to the map of exceptions. All the other accesses to this map are already properly synchronized thanks to the `counter`.
dakrone · Jul 24, 2023 · 72aef7e · 72aef7e
1 parent 2d9ea80
commit 72aef7e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/docs/changelog/97869.yaml b/docs/changelog/97869.yaml
@@ -0,0 +1,5 @@
+pr: 97869
+summary: Add missing sync on `indicesThatCannotBeCreated`
+area: CRUD
+type: bug
+issues: []
diff --git a/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java b/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
@@ -318,8 +318,10 @@ protected void doRun() {
                     @Override
                     public void onFailure(Exception e) {
                         final Throwable cause = ExceptionsHelper.unwrapCause(e);
-                        if (cause instanceof IndexNotFoundException) {
-                            indicesThatCannotBeCreated.put(index, (IndexNotFoundException) cause);
+                        if (cause instanceof IndexNotFoundException indexNotFoundException) {
+                            synchronized (indicesThatCannotBeCreated) {
+                                indicesThatCannotBeCreated.put(index, indexNotFoundException);
+                            }
                         } else if ((cause instanceof ResourceAlreadyExistsException) == false) {
                             // fail all requests involving this index, if create didn't work
                             for (int i = 0; i < bulkRequest.requests.size(); i++) {