Update code for CEF 124 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3DDevice1-based shared texture interface for accelerated rendering.
…recent CEF versions, using new language features. NOTE: This must also be added to the CMakeLists.txt from the cef-binary package, in order to build libcef_dll_wrapper properly.
… the new SHAREDNT-type handles cannot be retrieved via IDXGIResource->GetSharedHandle().
…ng ID3D11Device1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CEF 124, a new accelerated painting interface was introduced, using SHARED_NT handles now, via Direct3D 11.1.
The code has been modified to work with the newer CEF release.
As a quick-and-dirty patch, it makes the code render again, and it avoids the obvious exceptions and other issues.
However, this may not be the preferred way to use the new interface. Currently the shared textures are used directly, but their lifetime may not be guaranteed outside the OnAcceleratedPaint()-callback, so it may be better to make a copy inside the OnAcceleratedPaint(), and then use the copy for rendering.