Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy fixes #661

Merged
merged 1 commit into from
Jul 31, 2024
Merged

clippy fixes #661

merged 1 commit into from
Jul 31, 2024

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Jul 30, 2024

I used clippy with very pedantic lints (including absolutely useless lints) which gave some hints about making code more idiomatic

cargo clippy command
cargo clippy --all -- \
          -W clippy::all \
          -W clippy::pedantic \
          -W clippy::restriction \
          -W clippy::nursery \
          -W clippy::cargo \
          -A clippy::modulo_arithmetic \
          -A clippy::arithmetic_side_effects \
          -A clippy::missing_inline_in_public_items \
          -A clippy::implicit_return \
          -A clippy::default_numeric_fallback \
          -A clippy::std_instead_of_core \
          -A clippy::module_name_repetitions \
          -A clippy::question_mark_used \
          -A clippy::integer_division \
          -A clippy::shadow_reuse \
          -A clippy::single_call_fn \
          -A clippy::indexing_slicing \
          -A clippy::blanket_clippy_restriction_lints \
          -A clippy::missing_docs_in_private_items \
          -A clippy::std-instead-of-alloc \
          -A clippy::self_named_module_files \
          -A clippy::unseparated_literal_suffix \
          -A clippy::pub_use \
          -A clippy::partial_pub_fields \
          -A clippy::missing_trait_methods \
          -A clippy::float_arithmetic \
          -A clippy::cast_precision_loss \
          -A clippy::as_conversions \
          -A clippy::cast_possible_truncation \
          -A clippy::pattern_type_mismatch \
          -A clippy::integer_division_remainder_used \
          -A clippy::multiple-crate-versions || true

@dalance
Copy link
Owner

dalance commented Jul 31, 2024

Thanks!
I'll merge this PR.

@dalance dalance enabled auto-merge July 31, 2024 02:11
@dalance dalance merged commit 0acdfe5 into dalance:master Jul 31, 2024
7 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants