Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow look up of convertible types also in nested maps #49

Merged
merged 1 commit into from
May 26, 2020
Merged

Conversation

vandres
Copy link
Contributor

@vandres vandres commented May 11, 2020

This is a proposal to solve #47

@dalenguyen
Copy link
Owner

Hi @vandres, thanks for your contribution. I like the fact that you refactored a few helper functions. The nested key may not be a good practice because it applies to everything even though we may only one type of nested option (date or geo only).

I will merge this one and test it on a sample branch.

@dalenguyen dalenguyen changed the base branch from master to feature/nested May 26, 2020 03:42
@dalenguyen dalenguyen merged commit 6c7ea9a into dalenguyen:feature/nested May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants